Iliya Katushenock mod_moder
  • Russian
  • Just student

  • Joined on 2019-01-20
Iliya Katushenock commented on pull request blender/blender#128726 2024-10-11 06:29:25 +02:00
Curves: Align handles in transform operator

I mean MutableSpan<T> = ._for_witre() once instead of _for_write() in 2 or more function calls.

Iliya Katushenock commented on issue blender/blender#128867 2024-10-11 06:27:59 +02:00
Geometry Nodes: Warning Node doesn't work inside a group.

What the error-propagation setting of the node groups?

Iliya Katushenock commented on pull request blender/blender#128726 2024-10-10 21:01:57 +02:00
Curves: Align handles in transform operator

Function call is copy data to the stack to pass variables to the function.

  1. Span<T>(const Span<T> values) - okay.
  2. (const T *)(T *values) - okay.
  3. (T &values)(const T &value) -…
Iliya Katushenock commented on pull request blender/blender#128726 2024-10-10 20:38:05 +02:00
Curves: Align handles in transform operator

Also pay attention to & and const in my first comment/

Iliya Katushenock commented on pull request blender/blender#128638 2024-10-10 19:52:35 +02:00
Curves: Convert types when transforming

Shouldn't attributes api cove that and just retrieve VArray with single false?\

Iliya Katushenock commented on pull request blender/blender#128726 2024-10-10 19:49:40 +02:00
Curves: Align handles in transform operator
Iliya Katushenock commented on pull request blender/blender#128726 2024-10-10 19:49:39 +02:00
Curves: Align handles in transform operator

_for_write can be non trivial, it's better to create temporary variables on the stack for all data of the geometry like points positions or handles.

Iliya Katushenock commented on pull request blender/blender#128726 2024-10-10 19:49:37 +02:00
Curves: Align handles in transform operator

*static_cast<const CurvesTransformData *

Iliya Katushenock commented on pull request blender/blender#128726 2024-10-10 19:49:36 +02:00
Curves: Align handles in transform operator

Grain size can be 4096, loop body it pure vector math, also quite short. Might be even could be foreach_index_optimized<int>

Iliya Katushenock commented on pull request blender/blender#128726 2024-10-10 19:49:35 +02:00
Curves: Align handles in transform operator
Iliya Katushenock commented on pull request blender/blender#126988 2024-10-10 18:10:04 +02:00
Compositor: Implement Multi-Function Procedure Operation

I clearly do not see any usage of this thing in the PR.

Iliya Katushenock commented on pull request blender/blender#126988 2024-10-10 18:10:02 +02:00
Compositor: Implement Multi-Function Procedure Operation

To make compositor node tree totally compatible with other backends we will have to delete this at some point and just use BKE_type_conversions.hh. Same for float4 instead of ColorGeometry4f.

Iliya Katushenock commented on pull request blender/blender#126988 2024-10-10 18:10:01 +02:00
Compositor: Implement Multi-Function Procedure Operation

const std::string

Iliya Katushenock commented on pull request blender/blender#128775 2024-10-09 22:06:59 +02:00
Fix: Sculpt: Reduce clay strips z-axis influence

const float local_offset = math::abs(math::transform_point(mat, vert_positions[verts[i]]).z);

Iliya Katushenock closed issue blender/blender#128806 2024-10-09 18:18:59 +02:00
长度测量问题
Iliya Katushenock commented on issue blender/blender#128806 2024-10-09 18:18:56 +02:00
长度测量问题

For help using Blender, please try one of the community websites: https://www.blender.org/community/

If you think you found a bug, please submit a new report and carefully follow the instruction…

Iliya Katushenock commented on issue blender/blender#93909 2024-10-08 06:07:03 +02:00
Expand / Contract Selection Node
  1. Do not doe this by using Repeat zone.
  2. Its just algorithmically better and more correct to use Shortest Path.
Iliya Katushenock deleted branch fix_126024 from mod_moder/blender 2024-10-08 06:00:39 +02:00
Iliya Katushenock pushed to fix_126024 at mod_moder/blender 2024-10-07 21:46:12 +02:00
d96c6b6a7d init
49ab0bb844 Fix: Edge Slide: Vertex destination not matching edges intersection
580e0af309 Fix #128702: Edge Slide can cause Blender to freeze
9d09362c0c Fix #128698: GPv3: Layer adjustments are applied to original geometry
937b289137 Libs: Update OIIO+OSL+LibPNG+ShaderC
Compare 22 commits »