Iliya Katushenock mod_moder
  • Russian
  • Just student

  • Joined on 2019-01-20
Iliya Katushenock commented on pull request blender/blender#127888 2024-11-20 18:15:52 +01:00
Function Node: Add Bit Math node

Although this is acceptable for c++, i think this is seems like not good to limit a shift direction and number of bits. So here should be just one Shift operation with -max,+max shift range and ability to rotate bits by other operation.

Iliya Katushenock commented on issue blender/blender#130598 2024-11-20 18:05:31 +01:00
Geometry nodes viewer draws facecorner attributes (as text) on top of each other

Sorry, i didn't understand this report description. Is the bug is in the fact that overlay text for the same corner are stacked at the same vertex position?

Iliya Katushenock commented on issue blender/blender#130612 2024-11-20 18:00:19 +01:00
Geometry Nodes: Undefined Node in "Curve Volume Advection" Demo File

It seems you check demo file with experimental node in release build. Can you check if there is no such issue in daily build?

Iliya Katushenock commented on pull request blender/blender#130530 2024-11-19 22:06:34 +01:00
Attributes: Add 2D 16 bit integer type

Wonder is this type only a temporal solution for smooth move to float3 normals? Or int16_2 will be forever even then normals will be humane?

Iliya Katushenock commented on pull request blender/blender#130534 2024-11-19 19:26:23 +01:00
Cleanup: Use StringRef instead of std::string in a few cases

Oh, did not know what constexpr in a namespace implice static by default/!

Iliya Katushenock commented on pull request blender/blender#130175 2024-11-19 18:33:01 +01:00
Fix #130136: "Purge Unused Data" causing a crash when saving file

Mainly because duplication of the code in such simple case\

Iliya Katushenock deleted branch binary_search_if from mod_moder/blender 2024-11-19 11:06:24 +01:00
Iliya Katushenock commented on issue blender/blender#98577 2024-11-19 08:11:29 +01:00
Original index mapping for the extrude mesh node

Would be good to do that for other nodes too.

Iliya Katushenock commented on pull request blender/blender#130229 2024-11-18 21:33:04 +01:00
Refactor: Curves: Various changes to extrude operator

Well, i did not mean to make it shared, only simplify in way like: do_something_with_segements(Curves, Extra_Points, ...) -> do_something_with_segments(segments, addinition).

Iliya Katushenock pushed to binary_search_if at mod_moder/blender 2024-11-18 21:22:11 +01:00
507bbdbab6 remove assertion check
2529a933db Merge branch 'main' into binary_search_if
8e8d21a8ca Fix #130456: GP Render engine crash due to C/C++ mix
5ddf8a6495 Merge branch 'blender-v4.3-release'
1a40efbded Fix #130389: Cycles: Numerical issues in GGX_D with associative math flag
Compare 68 commits »
Iliya Katushenock commented on pull request blender/blender#130229 2024-11-18 21:17:53 +01:00
Refactor: Curves: Various changes to extrude operator

I means only naming\

Iliya Katushenock commented on pull request blender/blender#130380 2024-11-18 21:01:07 +01:00
Cleanup: BLI: Binary search first_if and last_if utils

Too bad that more complexity and less safety are chosen in favor of faster debug build\

Iliya Katushenock pushed to sample_field_node at mod_moder/blender 2024-11-18 20:59:10 +01:00
1c8cce1200 Disable data race, still artifacts..
9a93078e98 Merge branch 'main' into sample_field_node
d4f321fe54 Overlay: Add a pre_draw step and use submit_only for PassMain
d50d287924 Draw: Add specialized generate_commands for PassSortable
5586533cc8 Overlay: Add image_plane_depth_bias shader
Compare 54 commits »
Iliya Katushenock deleted branch sample_index_handle_copy from mod_moder/blender 2024-11-18 20:54:55 +01:00
Iliya Katushenock closed pull request blender/blender#122258 2024-11-18 20:54:47 +01:00
WIP: Geometry Nodes: The Sample Index node handling of Index field
Iliya Katushenock commented on pull request blender/blender#130229 2024-11-18 20:49:16 +01:00
Refactor: Curves: Various changes to extrude operator

Hope if all this code complexity can be avoided by

Iliya Katushenock commented on pull request blender/blender#130229 2024-11-18 20:49:15 +01:00
Refactor: Curves: Various changes to extrude operator

In case you'd like to improve this section of the code would be good to avoid void do_something() in favor of T something_from(a) or something_convert_to(in, out), .. .

Iliya Katushenock commented on pull request blender/blender#130229 2024-11-18 20:49:13 +01:00
Refactor: Curves: Various changes to extrude operator

Its better to use abstract term (like groups and group_i) rather then mix geometrical terms (like curve) in to generic (abstract) function like compress_intervals (etc how curves are related intervals?...).

Iliya Katushenock commented on pull request blender/blender#130229 2024-11-18 20:49:12 +01:00
Refactor: Curves: Various changes to extrude operator

Too bad:

Iliya Katushenock commented on pull request blender/blender#130229 2024-11-18 20:49:10 +01:00
Refactor: Curves: Various changes to extrude operator

intervals_by_curve.index_range().drop_front(1)