Iliya Katushenock mod_moder
  • Russian
  • Just student

  • Joined on 2019-01-20
Iliya Katushenock commented on pull request blender/blender#127873 2024-09-25 05:52:42 +02:00
Geometry Nodes: Add "Merge Layers" node

I think inline node options will be here for a long time or will be removed with some general handling of older files, in another hand todat this is more complicated dealing with the node and…

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-25 05:49:51 +02:00
Geometry Nodes: Add "Merge Layers" node

For me its just more complicated if params is crawls more deeper and deeper in a stack and its better to just pass all such arguments from the top level where simple switch can be.

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-25 05:47:01 +02:00
Geometry Nodes: Add "Merge Layers" node

We need to transformation * ~transformation so here is not accurate unit matrix in result, does not seems like good thing to be used as interface of operation just to skip coping.

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-25 05:44:25 +02:00
Geometry Nodes: Add "Merge Layers" node

Ah, right\

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-24 19:17:14 +02:00
Geometry Nodes: Add "Merge Layers" node

if (meta_data.data_type == string) skip;

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-24 19:15:09 +02:00
Geometry Nodes: Add "Merge Layers" node
Iliya Katushenock commented on pull request blender/blender#127873 2024-09-24 19:15:08 +02:00
Geometry Nodes: Add "Merge Layers" node

Shouldn't this be at geometry nodes modifier level? I do not know is there is any such case but it seems like invariant of unique names also can be used in other modifiers that would wrong with this change\

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-24 19:15:06 +02:00
Geometry Nodes: Add "Merge Layers" node

const GeoNodeExecParams &params -> const Field<bool> &selection_field

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-24 19:15:05 +02:00
Geometry Nodes: Add "Merge Layers" node

extrace_input

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-24 19:15:04 +02:00
Geometry Nodes: Add "Merge Layers" node

: int8_t

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-24 19:15:03 +02:00
Geometry Nodes: Add "Merge Layers" node

Use bNode::custom1

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-24 19:15:02 +02:00
Geometry Nodes: Add "Merge Layers" node

MutableSpan<T>\

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-24 19:15:01 +02:00
Geometry Nodes: Add "Merge Layers" node

if (meta_data.domain) != bke::AttrDomain::Layer) skip;

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-24 19:15:00 +02:00
Geometry Nodes: Add "Merge Layers" node

/* #join_geometries can skip such case but transformation can not be skiped later for free. */

Iliya Katushenock commented on pull request blender/blender#127873 2024-09-24 19:14:59 +02:00
Geometry Nodes: Add "Merge Layers" node

GroupedSpan<int> dst_to_src_map

Iliya Katushenock closed issue blender/blender#128009 2024-09-23 19:11:55 +02:00
Geometry nodes simultion zone drops animation data
Iliya Katushenock commented on issue blender/blender#128009 2024-09-23 19:11:51 +02:00
Geometry nodes simultion zone drops animation data

Simulation zone takes the input value only once, after that value is keeped as-is in the zone loop, read geometry just by zone-dependent nodes.

Iliya Katushenock commented on issue blender/blender#127492 2024-09-23 19:09:26 +02:00
Line art Edge Marks data isn't kept with Separate Geometry Node.

As i can see here is the same issue as was with UV custom data, this simply not an attribute.

Iliya Katushenock commented on pull request blender/blender#123641 2024-09-22 23:30:40 +02:00
Compositor: node fast viewing

Do not recreate node every time, just move old one to a new place (#121951), use viewer by clicking on a socket, eye icon in the header, ...

Iliya Katushenock commented on pull request blender/blender#123641 2024-09-22 19:03:11 +02:00
Compositor: node fast viewing

In geometry nodes we have specific behavior of the viewer node which is probably should be used and in compositor.