Iliya Katushenock mod_moder
  • Russian
  • Just student

  • Joined on 2019-01-20
Iliya Katushenock closed issue blender/blender#109493 2023-06-29 16:00:28 +02:00
WeighetNormal + Autosmooth prevents objects to become Flat Shaded.
Iliya Katushenock commented on issue blender/blender#109493 2023-06-29 16:00:24 +02:00
WeighetNormal + Autosmooth prevents objects to become Flat Shaded.

Thanks for the report, but the issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors.

For…

Iliya Katushenock commented on issue blender/blender#109493 2023-06-29 15:59:17 +02:00
WeighetNormal + Autosmooth prevents objects to become Flat Shaded.

Because turning it off is not part of the set float function.

Iliya Katushenock commented on issue blender/blender#109513 2023-06-29 15:38:11 +02:00
Regression: library override does not work with modifiers

Hi @Louis-Hoeng, thanks for report. Can you say, what version of blender worked for you?

Iliya Katushenock closed issue blender/blender#109504 2023-06-29 13:34:27 +02:00
Regreesion: Mouse wheel stop working for GRS
Iliya Katushenock commented on issue blender/blender#109503 2023-06-29 13:18:22 +02:00
F2 addon Crashes Blender if F pressed on a single vert

Hey, can you move this report to add-ons repo?

Iliya Katushenock opened issue blender/blender#109504 2023-06-29 13:16:32 +02:00
Regreesion: Mouse wheel stop working for GRS
Iliya Katushenock commented on issue blender/blender#109493 2023-06-29 13:06:24 +02:00
WeighetNormal + Autosmooth prevents objects to become Flat Shaded.

Hi, thanks for report, there seems to be some confusion to me. Make Smooth and Make Flat are 2 functions that change polygon flags. But Auto Smooth changes the mesh's setting. If you try to make…

Iliya Katushenock commented on pull request blender/blender#109405 2023-06-29 01:46:36 +02:00
WIP: Geometry Nodes: Easing Node

@CharlieJolly I'm also not entirely sure about this, but it seems that if I'm not reviewing, I can't do it all at once... Yeah, thinking about it now, I'm very good at spamming.. sorry.

As a…

Iliya Katushenock commented on pull request blender/blender#109405 2023-06-29 01:40:33 +02:00
WIP: Geometry Nodes: Easing Node

NodeEasing *data = node_storage(params.node());

Iliya Katushenock commented on pull request blender/blender#109405 2023-06-29 01:39:50 +02:00
WIP: Geometry Nodes: Easing Node

switch (NodeEasingOperation(data->operation)) {

Iliya Katushenock commented on pull request blender/blender#109405 2023-06-29 01:37:48 +02:00
WIP: Geometry Nodes: Easing Node

Try to use int instead of int64_t in geometry nodes code if this possible.

Iliya Katushenock commented on pull request blender/blender#109405 2023-06-29 01:37:07 +02:00
WIP: Geometry Nodes: Easing Node

If loop body is just math, foreach_index_optimized<int> might better.

Iliya Katushenock commented on pull request blender/blender#109405 2023-06-29 01:35:38 +02:00
WIP: Geometry Nodes: Easing Node

Try to make all numeric temporal variables and function arguments constants. It's very easy when you don't need to follow the state of the variable throughout the body of the code.

Iliya Katushenock commented on pull request blender/blender#109405 2023-06-29 01:34:15 +02:00
WIP: Geometry Nodes: Easing Node

Don't omit creating scope for if statements (https://wiki.blender.org/wiki/Style_Guide/C_Cpp).

Iliya Katushenock commented on pull request blender/blender#109405 2023-06-29 01:31:08 +02:00
WIP: Geometry Nodes: Easing Node

Shouldn't C-style cast be used. Function style cast for numeric types (https://wiki.blender.org/wiki/Style_Guide/C_Cpp).

Iliya Katushenock commented on pull request blender/blender#109405 2023-06-29 01:26:36 +02:00
WIP: Geometry Nodes: Easing Node

Same as above.

Iliya Katushenock commented on pull request blender/blender#109405 2023-06-29 01:23:59 +02:00
WIP: Geometry Nodes: Easing Node

Might be better to create new temporal const value and make all function arguments const.

Iliya Katushenock commented on pull request blender/blender#109405 2023-06-29 01:21:03 +02:00
WIP: Geometry Nodes: Easing Node

(out) -> out?