Iliya Katushenock mod_moder
  • Russian
  • Just student

  • Joined on 2019-01-20
Iliya Katushenock commented on pull request blender/blender#125277 2024-07-23 10:44:09 +02:00
Cleanup: Replace GSet with blender::Set in sculpt_boundary.cc

Probably more efficient to just call ensure(BOUNDARY_INDICES_BLOCK_SIZE) to pre allocate this, but keep use original inline size?

Iliya Katushenock commented on pull request blender/blender#124986 2024-07-23 10:39:39 +02:00
Fix #123179: can't select multiple snap target elements in UV Editor

Use C++ style cast.

Iliya Katushenock commented on pull request blender/blender#125244 2024-07-22 21:50:10 +02:00
Experiment: UI: Allow use custom icons

<=

Iliya Katushenock commented on pull request blender/blender#123378 2024-07-22 20:11:05 +02:00
Compositor: Support multi-pass compositing for EEVEE

const int i :

Iliya Katushenock commented on pull request blender/blender#123378 2024-07-22 20:11:05 +02:00
Compositor: Support multi-pass compositing for EEVEE

const int64_t pass_offset

Iliya Katushenock commented on pull request blender/blender#123378 2024-07-22 20:11:04 +02:00
Compositor: Support multi-pass compositing for EEVEE

const int i

Iliya Katushenock commented on pull request blender/blender#123378 2024-07-22 20:11:03 +02:00
Compositor: Support multi-pass compositing for EEVEE

const int i

Iliya Katushenock commented on pull request blender/blender#123378 2024-07-22 20:11:02 +02:00
Compositor: Support multi-pass compositing for EEVEE

Its better to add check to deduplicate check of already passed node groups, see: #104465

Iliya Katushenock commented on pull request blender/blender#123378 2024-07-22 20:11:01 +02:00
Compositor: Support multi-pass compositing for EEVEE

StringRef(output->identifier) == "Image"

Iliya Katushenock commented on pull request blender/blender#123378 2024-07-22 20:11:01 +02:00
Compositor: Support multi-pass compositing for EEVEE

for (const int i : IndexRange(cryptomatte_layers_count))

Iliya Katushenock commented on pull request blender/blender#118670 2024-07-22 19:58:08 +02:00
VSE: Add anim manager

is_empty()

Iliya Katushenock commented on pull request blender/blender#118670 2024-07-22 19:58:07 +02:00
VSE: Add anim manager

const int count

Iliya Katushenock commented on pull request blender/blender#118670 2024-07-22 19:58:06 +02:00
VSE: Add anim manager

strips_sorted = strips;

Iliya Katushenock commented on pull request blender/blender#118670 2024-07-22 19:58:05 +02:00
VSE: Add anim manager

for (const int i : this->anims.index_range())

Iliya Katushenock commented on pull request blender/blender#118670 2024-07-22 19:58:04 +02:00
VSE: Add anim manager

Should be const

Iliya Katushenock commented on pull request blender/blender#118670 2024-07-22 19:58:03 +02:00
VSE: Add anim manager

Just for record, its much better to just use EnumerableThreadSpecific to accumulate elements from different threads and in result just move all of them into class fields instead of have muted just for that.

Iliya Katushenock commented on pull request blender/blender#118670 2024-07-22 19:58:02 +02:00
VSE: Add anim manager

const int i : range

Iliya Katushenock commented on pull request blender/blender#118670 2024-07-22 19:58:01 +02:00
VSE: Add anim manager

release_from_all_strips(void) -> release_from_all_strips()

Iliya Katushenock commented on pull request blender/blender#118670 2024-07-22 19:57:59 +02:00
VSE: Add anim manager

Result should be by value.