Miguel Pozo pragma37
  • Joined on 2018-04-26
Miguel Pozo deleted branch pull-draw-fix-uninitialized-bounds from pragma37/blender 2024-04-16 17:19:33 +02:00
Miguel Pozo merged pull request blender/blender#120591 2024-04-16 17:19:30 +02:00
Fix: Draw: EEVEE-Next shadow flickering and other uninitialized bounds fixes
Miguel Pozo pushed to main at blender/blender 2024-04-16 17:19:29 +02:00
cec57e9138 Fix: Draw: EEVEE-Next shadow flickering and other uninitialized bounds fixes
Miguel Pozo commented on issue blender/blender#120100 2024-04-16 16:52:34 +02:00
EEVEE-Next: Reduce longer compilation time

There's been a pretty bad regression in compile times recently:

Miguel Pozo created branch test-compile-times in pragma37/blender 2024-04-16 16:27:43 +02:00
Miguel Pozo pushed to test-compile-times at pragma37/blender 2024-04-16 16:27:43 +02:00
9c53a473c9 print shader compilation times
Miguel Pozo pushed to pull-draw-fix-uninitialized-bounds at pragma37/blender 2024-04-16 16:12:47 +02:00
eae0286c64 Remove all bounds.bounding_sphere.w != -1.0 checks
Miguel Pozo commented on pull request blender/blender#120591 2024-04-16 16:11:05 +02:00
Fix: Draw: EEVEE-Next shadow flickering and other uninitialized bounds fixes

bounds.bounding_sphere.w == -1.0f only means the culling is disabled (which does not always means the bounding box is invalid

At the moment disabling culling effectively means the bounding…

Miguel Pozo commented on issue blender/blender#120403 2024-04-15 20:47:55 +02:00
NPR Design

@Traslev Maybe? We could allow reading the render targets and AOVs from the previous frame. I can see a few use cases and it shouldn't be that hard to support.

Miguel Pozo pushed to pull-eevee-jittered-shoft-shadows at pragma37/blender 2024-04-15 20:22:38 +02:00
57af2e16e8 FIx shadow_tag_usage_tilemap_punctual
Miguel Pozo commented on pull request blender/blender#119753 2024-04-15 20:18:21 +02:00
EEVEE-Next: Jittered Soft Shadows

I mean the tilemap.viewmat is not changed, which is the viewmat the shadow is rendered with. So you effectively only jitter the tracing / projection direction (I think, not sure) but the…

Miguel Pozo commented on pull request blender/blender#119753 2024-04-15 20:04:49 +02:00
EEVEE-Next: Jittered Soft Shadows

How is this shady? This is just computing the shadow map local space. I moved it here because I found way more confusing the way it was. Also, doesn't that mess some computations in `shadow_ray_gen…

Miguel Pozo commented on pull request blender/blender#119753 2024-04-15 19:57:06 +02:00
EEVEE-Next: Jittered Soft Shadows

I've updated the code, but I'm not sure if it's right. The test is disabled and fails even in main if I enable it back.

Miguel Pozo commented on pull request blender/blender#119753 2024-04-15 19:55:12 +02:00
EEVEE-Next: Jittered Soft Shadows

Yes, I mentioned it at the last week meeting, and you seemed to agree (?). Maybe I didn't explain it properly.

I don't understand what you mean by not changing the shadow projection.

The shading…

Miguel Pozo commented on pull request blender/blender#119753 2024-04-15 19:50:56 +02:00
EEVEE-Next: Jittered Soft Shadows

It's better to just pass light radius

The problem is, what radius? The original or the one set by the Light module? The compute_projection_boundaries receives both.

I've cleaned the code a…

Miguel Pozo pushed to pull-eevee-jittered-shoft-shadows at pragma37/blender 2024-04-15 19:33:15 +02:00
c77b7143cb Cleanup
Miguel Pozo pushed to pull-eevee-jittered-shoft-shadows at pragma37/blender 2024-04-15 19:26:18 +02:00
2b33571915 Fix tests?
01a1220287 Shadow parameters cleanup
38781f757c JItter Overblur defaults
e50191532a Skip jittering light resyncs
78f5ff9441 Remove custom data cleanup
Compare 295 commits »
Miguel Pozo commented on issue blender/blender#114130 2024-04-15 17:15:16 +02:00
EEVEE Next: Volume render cuts off front or backside of the object

I can't reproduce it anymore, but I'm not sure if it's because the underlying issue has been fixed, or because the recently implemented volume bounds detection and the dither hides it. @fclem ?

Miguel Pozo pushed to main at blender/blender 2024-04-15 16:40:59 +02:00
65d9311291 Fix: EEVEE-Next: Shadow Ray accumulation
Miguel Pozo pushed to pull-draw-fix-uninitialized-bounds at pragma37/blender 2024-04-15 14:04:06 +02:00
9f3312172b Feedback
9d1dbec0a4 Merge branch 'main' into pull-draw-fix-uninitialized-bounds
e3b8d45c93 Cleanup: move mallocn to c++
2fefb39e22 GPv3: Wrong object type
a39a967f11 I18N: Updated UI translations from git/weblate (0e1a4199cc08b52).
Compare 100 commits »