Miguel Pozo pragma37
  • Joined on 2018-04-26
Miguel Pozo pushed to pull-eevee-shadow-resolution-scale at pragma37/blender 2024-03-20 15:52:08 +01:00
fb88e8df19 Fix typo
4964295d34 Merge branch 'main' into pull-eevee-shadow-resolution-scale
6d3ac72a29 Merge branch 'blender-v4.1-release'
87de8109b7 Fix: Build error from misplaced const in recent commit
cb3975c045 Fix #119642: Orbit around selection ignores geometry bounds
Compare 278 commits »
Miguel Pozo pushed to pull-transparent-shadow-threshold at pragma37/blender 2024-03-19 20:10:20 +01:00
06bde39d7f Remove unused include
Miguel Pozo pushed to pull-eevee-transparent-shadows at pragma37/blender 2024-03-19 20:07:07 +01:00
b360d0ef36 Revert threshold changes merge
Miguel Pozo commented on pull request blender/blender#119480 2024-03-19 20:02:19 +01:00
EEVEE-Next: Jittered Shadow Transparency

I've updated the property names so we don't break compat, but I kept the UI label the same. We can change it once jittered soft shadows land.

Miguel Pozo pushed to pull-eevee-transparent-shadows at pragma37/blender 2024-03-19 20:00:19 +01:00
1e677b992e Merge branch 'main' into pull-eevee-transparent-shadows
10556af0e9 Rename
787818d21d EEVEE-Next: Fix shader compilation error caused by resource macro
23dce15f67 EEVEE-Next: Horizon Scan: Use Spherical harmonics
893430a2c7 EEVEE-Next: Add correct support for volume anisotropy from probe volumes
Compare 156 commits »
Miguel Pozo commented on pull request blender/blender#119526 2024-03-19 18:51:19 +01:00
EEVEE-Next: Fix transparent shadows convergence

Can you try noise_function(g_data.P + noise_offset); then?

That can cause troubles on planes that are aligned "just in the right way", and probably in other cases. Using the noise_offset as…

Miguel Pozo commented on pull request blender/blender#119480 2024-03-19 17:55:14 +01:00
EEVEE-Next: Jittered Shadow Transparency

But I wonder if we really need this property. EEVEE legacy didn't refresh the transparent shadows in the viewport at all if soft shadows were disabled.

I think it's needed, otherwise we're…

Miguel Pozo pushed to pull-eevee-transparent-shadows at pragma37/blender 2024-03-19 17:46:18 +01:00
b01e8daa2e Add viewport suffix and clarification
a90e32ffe8 Fix typo
Compare 2 commits »
Miguel Pozo commented on pull request blender/blender#119526 2024-03-19 17:15:29 +01:00
EEVEE-Next: Fix transparent shadows convergence

I tried all your suggestions and it still shows the same issue. I don't think it's an issue with fract(rand + offset), but simply that the correlation between front and back layers stays the…

Miguel Pozo commented on pull request blender/blender#118924 2024-03-19 16:36:59 +01:00
EEVEE-Next: Horizon Scan: Use Spherical harmonics

Oh... because the horizon scan is driven by the AOData from the AmbientOcclussion module. But these new properties are added to RayTraceData directly. I find that quite confusing, TBH.

Miguel Pozo suggested changes for blender/blender#118924 2024-03-19 16:16:45 +01:00
EEVEE-Next: Horizon Scan: Use Spherical harmonics

I only took a quick look at the code, but I've tested the patch on my RTX GPU and on my cheap integrated AMD laptop and the quality and performance are better on both.

Miguel Pozo commented on pull request blender/blender#118924 2024-03-19 16:16:44 +01:00
EEVEE-Next: Horizon Scan: Use Spherical harmonics

Just a nitpick, but I would make clear that this also has a render time cost, not only a memory cost.

Miguel Pozo commented on pull request blender/blender#118924 2024-03-19 16:16:43 +01:00
EEVEE-Next: Horizon Scan: Use Spherical harmonics

Why are you using the gtao term for the DNA property?

Miguel Pozo commented on pull request blender/blender#118924 2024-03-19 16:16:42 +01:00
EEVEE-Next: Horizon Scan: Use Spherical harmonics

There are some functions duplicated between the denoise and resolve shaders.

Miguel Pozo deleted branch pull-motion-blur-playback from pragma37/blender 2024-03-18 20:39:51 +01:00
Miguel Pozo merged pull request blender/blender#119484 2024-03-18 20:39:48 +01:00
EEVEE-Next: Disable viewport motion blur outside of playback
Miguel Pozo pushed to main at blender/blender 2024-03-18 20:39:48 +01:00
58eab5e3be EEVEE-Next: Disable viewport motion blur outside of playback
Miguel Pozo commented on pull request blender/blender#119480 2024-03-18 20:36:54 +01:00
EEVEE-Next: Jittered Shadow Transparency

The force push doesn't contain any change. I just reverted the last 3 commits, since I've pushed them here by error.

Miguel Pozo commented on pull request blender/blender#119526 2024-03-18 20:34:32 +01:00
EEVEE-Next: Fix transparent shadows convergence

I ended up using pcg4d since we have to take the sample offset into account and doing fract(hash + noise) was giving pretty bad results for some reason: ![imagen](/attachments/14da9e5e-9fdb-4d…

Miguel Pozo pushed to pull-eevee-transparent-shadows at pragma37/blender 2024-03-18 20:24:46 +01:00