I've moved the formatting and printing to a separate class.
It would be nice to move more things to the gpu::Context itself (like the level checking and the begin/end mismatches), but I'm not…
Is this a debug feature, though? "debug-gpu" kind of implies a debug GPU context, which this doesn't use (and shouldn't!). For level, I didn't include it in the name because the level is optional…
I personally find that having this-> everywhere adds unnecessary noise that hurts readability.
While I've never found it necessary (free functions are typically preceded by their module…
SwapChain is not really used in too many places, and the only ones that use pointers to chain elements are DoF and Film (which I think needs to be updated as well).
I didn't make the changes to…
I can see how motion blur while working on the viewport can be undesirable, and toggling it all the time can be annoying. I don't really think being on camera view or not makes a difference…
@Jeroen-Bakker If you could check the performance on AMD and on Metal, that would be really nice.
this-> in non-templated inheritance is innecesary. 😜
No, but seriously, it's not in the style guide and I don't find it's required for readability here.
I guess that would only work if you assume offset < len? Either way, this is being called only a few times per frame.