Hey sorry didn't mean for this change list to get reviewed. I was moving from Linux to Windows so, I pushed the changes to pick up on Windows. Should have pushed to a different branch!
bvh_file and bvh_file_oro are loaded by hiprt64.dll. If moved to where rest of the precompiled kernels are, hiprt64 will not be able to load them.
I am not sure where to move this part. I was falling back to the same logic as One API: 3acb5ae41b/intern/cycl…
No
WITH_CYCLES_HIP_BINARIES?The
WITH_CYCLES_HIP_BINARIESare taken care by the release configuration (in theblender_release.cmake).The issue can be seen before building…
@Alaska the device part of the code are disabled. So, the intersection returns false all the time and that's why part of the object is missing. I will fix and open a pull request.
If you start with a clean Linux environment (as described in some earlier comment) and clean checkout, this should work:
- Apply patch against the latest
main branchmake deps-…
Right now, this is how it is laid out: Cycles stand-alone: hiprt64.dll and shader binaries (hipfb files) are in the root directory Blender full build: hiprt64.dll and shader binaries are in…
@Sergey I updated the install path as well. Please let me know of any more concerns. I am eager to get this pull request merged.
It also hardcodes compilation to a specific structure of percompiled libraries folder, making it harder to fit into Linux distros which ship Blender and don't use our precompiled libraries.
@S…
Anyway, I will do away with version.txt and use the header to get the version instead for both Windows and Linux.
@Sergey how should Cycles standalone be handled. The binaries should go wherever hiprt.dll goes. That also means for Linux without precompiled binaries, these binaries should get built and copied…
Not sure what's going on here. Looks fine in the branch on its ownhttps://projects.blender.org/salipour/AMD_HIPRT/src/branch/HIPRT_OPEN_SOURCE/build_files/build_environment/cmake/harvest.cmake htt…
These two files are loaded by hiprt64.dll, so they have to be copied somewhere that hiprt64.dll can find them.
Oh! I misunderstood your earlier comment about version.txt not being detected. So, you meant version.txt didn't get copied into the lib folder. It worked for me on both Ubuntu and Windows. I will…