sean-murray
0 Followers · 1 Following
  • Joined on 2023-09-13
Repositories
1
 Projects Public Activity Starred Repositories
sean-murray pushed to quick_radius_fix at sean-murray/blender 2024-10-03 14:21:26 +02:00
5f13b51177 changed 'Radius' to 'Shrink/Fatten' to match top menu
sean-murray commented on pull request blender/blender#128532 2024-10-03 14:16:05 +02:00
Fix #128430: GPv3: Crash using "Shrink/Fatten" operator

sounds good. will adjust now.

sean-murray created pull request blender/blender#128532 2024-10-03 13:40:37 +02:00
changed grease pencil radius operator flag for point mode
sean-murray created branch quick_radius_fix in sean-murray/blender 2024-10-03 13:37:42 +02:00
sean-murray pushed to quick_radius_fix at sean-murray/blender 2024-10-03 13:37:42 +02:00
0e8f601144 changed grease pencil radius operator flag for point mode
8477a273dd Merge branch 'blender-v4.3-release'
4cefac0da3 Fix: Remove incorrect sculpt assert
65d56e6ae4 Merge branch 'blender-v4.3-release'
4a679470b6 Fix: USD: collection creation during import assigned extra fake user
Compare 10 commits »
sean-murray commented on issue blender/blender#128430 2024-10-02 23:10:32 +02:00
GPv3: Crash when using radius (shrink/fatten) opeartor

Hi, looks like support for gpv3 is not added yet. Crashing in legacy code.

I dug in a little bit and I think it's just a matter of the wrong flag being set under point mode for `VIEW3D_MT_grea…

sean-murray commented on pull request blender/blender#128398 2024-10-02 19:10:52 +02:00
GPv3: Split Operator

Any chance you could point me to an example of this pattern? Everything I'm finding seems to use a MutableSpan<int>.

sean-murray commented on pull request blender/blender#128398 2024-10-01 22:24:40 +02:00
GPv3: Split Operator

I aksed in context that its seems that everything that you need is to use join(delete(inverse(selection)), curve.copy_selected(invese(selection)))

Ah, I see. That was kind of what I thought…

sean-murray commented on pull request blender/blender#128398 2024-10-01 20:20:38 +02:00
GPv3: Split Operator

Is there is no yet operator for points deletion from the curve yet?

Yes, that's what I used as a reference for this. Why do you ask?

Looks good to me, just had some cosmetic suggestions…

sean-murray pushed to grease_pencil_v3_split at sean-murray/blender 2024-10-01 20:09:34 +02:00
5f1fbc4659 - added operator to dropdown and context menus
sean-murray commented on pull request blender/blender#128398 2024-10-01 19:06:19 +02:00
GPv3: Split Operator

Noted, thanks.

sean-murray commented on pull request blender/blender#128398 2024-10-01 19:00:39 +02:00
GPv3: Split Operator

This is insightful, thanks! I'll take a look and see if I can switch it correctly, I'm interested in matching the overall 'blender way' of doing things.

sean-murray commented on pull request blender/blender#128398 2024-10-01 18:59:19 +02:00
GPv3: Split Operator

I agree, fixed.

sean-murray commented on pull request blender/blender#128398 2024-10-01 18:57:24 +02:00
GPv3: Split Operator

I agree, this is a naming oversight on my part. 'Simpler' is a vestigial note to myself comparing it to a more convoluted function I tried and then deleted. Will rename this.

sean-murray commented on pull request blender/blender#128398 2024-10-01 05:15:38 +02:00
GPv3: Split Operator

ah my mistake, I thought it was still open based on blender/blender#112858. Do you know where I should check to make sure I'm not duplicating someone else's…

sean-murray pushed to grease_pencil_v3_split at sean-murray/blender 2024-10-01 03:55:23 +02:00
5048445cd5 even more cleanup (how embarassing)
sean-murray pushed to grease_pencil_v3_split at sean-murray/blender 2024-10-01 03:42:20 +02:00
306b38f99b yet more clean up
sean-murray created pull request blender/blender#128398 2024-10-01 03:00:00 +02:00
GPv3: Split Operator
sean-murray created branch grease_pencil_v3_split in sean-murray/blender 2024-10-01 02:50:56 +02:00
sean-murray pushed to grease_pencil_v3_split at sean-murray/blender 2024-10-01 02:50:56 +02:00
29edfc15f1 more clean up
85c25a3d1d undeleted find_curve_ranges
f1a7fffba0 some cleanup
612ffa90e1 cyclical split seems to work! needs cleanup though.
cda79cd097 Okay, not crashing and persistent non-split cyclics but splitting a cyclic kills join
Compare 10 commits »