studio/blender-studio-pipeline
13
30
Fork 19
Code Issues 20 Pull Requests 4 Projects Releases 1 Activity

Remap: Refactor scripts #177

Merged
Nick Alberelli merged 17 commits from :feature/refactor-remap-script into main 2023-12-07 16:17:27 +01:00
Conversation 1 Commits 17 Files Changed 5 +251 -123
Nick Alberelli commented 2023-12-05 17:09:15 +01:00
Member
Copy Link

What's Changed?

  • Remap scripts are consolidated into a single remap script
  • Updated README to explain new remap workflow

New Remap Tool Demo

## What's Changed? - Remap scripts are consolidated into a single remap script - Updated README to explain new remap workflow ### New Remap Tool Demo <video src="/attachments/b76d1fe5-5eda-4269-a8eb-5f79096decbe" title="2023-12-06 16-25-40.mkv" controls></video>
2023-12-06 16-25-40.mkv
8.4 MiB
Nick Alberelli force-pushed feature/refactor-remap-script from eeae359d90 to 42d2c144ef 2023-12-06 21:08:33 +01:00 Compare
Nick Alberelli added 1 commit 2023-12-06 22:34:52 +01:00
Nick Alberelli changed title from WIP: Remap: Refactor scripts to Remap: Refactor scripts 2023-12-06 22:35:03 +01:00
Nick Alberelli requested review from Sebastian Parborg 2023-12-06 22:35:14 +01:00
Sebastian Parborg reviewed 2023-12-07 15:24:58 +01:00
Sebastian Parborg left a comment
Member
Copy Link

From watching the video, functionality seems fine.
If you are going to post the video elsewhere, I would increase the sound volume as it is quite low right now.

I only have a commend about the readme file that seems a bit outdated still.

From watching the video, functionality seems fine. If you are going to post the video elsewhere, I would increase the sound volume as it is quite low right now. I only have a commend about the readme file that seems a bit outdated still.
scripts/remap/README.md Outdated
@ -11,0 +8,4 @@
3. Now you are ready to re-organize your mapped directory, move files into different folders, rename files and remove duplicates.
4. Re-run the remap tool via `python -m remap` to update your map with the new file locations. The tool will print a bbatch, copy this for use in step 6.
5. Enter bbatch directory `cd blender-studio-pipeline/scripts/bbatch`
6. Run provided bbatch command, similar to `python -m bbatch /my_files/ --script /{path_to_script}/remap_blender_paths_for_my_files.py --nosave --recursive` to update all references to the remapped directory contents in your .blend files.
Sebastian Parborg commented 2023-12-07 15:11:09 +01:00
Member
Copy Link

Hmm, this command seems out of date?
The python file is not called remap_blender_paths_for_my_files.py anymore and it also takes the json file path as a command now.

I would also drop the leading slashed in /my_files/ and /{path_to_script}.

Also to make it consistent I would do convert my_files/ to {my_files}/ to indicate that this is something the user has to replace.

Hmm, this command seems out of date? The python file is not called `remap_blender_paths_for_my_files.py` anymore and it also takes the json file path as a command now. I would also drop the leading slashed in `/my_files/` and `/{path_to_script}`. Also to make it consistent I would do convert `my_files/` to `{my_files}/` to indicate that this is something the user has to replace.
Nick Alberelli commented 2023-12-07 16:15:59 +01:00
Author
Member
Copy Link

Thank you for pointing that out. I have updated the README with this commit 104fb27eab thank you!

Thank you for pointing that out. I have updated the README with this commit 104fb27eab223b16d1a2c50e24f240126b1d7c81 thank you!
TinyNick marked this conversation as resolved
Nick Alberelli added 1 commit 2023-12-07 16:15:34 +01:00
Nick Alberelli commented 2023-12-07 16:16:38 +01:00
Author
Member
Copy Link

From watching the video, functionality seems fine.
If you are going to post the video elsewhere, I would increase the sound volume as it is quite low right now.

I only have a commend about the readme file that seems a bit outdated still.

No the video was just for the purposes of this PR, and yes I am having some mic issues, should be resolved soon :) Thank You! Will merge now

> From watching the video, functionality seems fine. > If you are going to post the video elsewhere, I would increase the sound volume as it is quite low right now. > > I only have a commend about the readme file that seems a bit outdated still. No the video was just for the purposes of this PR, and yes I am having some mic issues, should be resolved soon :) Thank You! Will merge now
Nick Alberelli merged commit 844c6c7389 into main 2023-12-07 16:17:27 +01:00
Nick Alberelli deleted branch feature/refactor-remap-script 2023-12-07 16:17:28 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Sebastian Parborg
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-pipeline#177
No description provided.
Delete Branch ":feature/refactor-remap-script"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?