studio/blender-studio-tools
13
32
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

Add project-tools #142

Merged
Francesco Siddi merged 26 commits from ZedDB/blender-studio-pipeline:project-helper-tools into main 2023-08-31 20:33:04 +02:00
Conversation 4 Commits 26 Files Changed 10 +679
Sebastian Parborg commented 2023-08-09 18:00:33 +02:00
Member
Copy Link

This is a set of scripts that makes it easier to deploy Blender into a shared folder on a network drive.

Most of the functionality should be working, but the downloading of addons from this repository is not working as the main.zip does not contain git lfs files. This is consistent with how github and gitlab functions as well.
So that means that if we want to track live repos that contains git lfs files, we will have to also depend on git + git-lfs in our scripts.

This is a set of scripts that makes it easier to deploy Blender into a shared folder on a network drive. Most of the functionality should be working, but the downloading of addons from this repository is not working as the `main.zip` does not contain git lfs files. This is consistent with how github and gitlab functions as well. So that means that if we want to track live repos that contains git lfs files, we will have to also depend on git + git-lfs in our scripts.
Sebastian Parborg added 18 commits 2023-08-09 18:00:35 +02:00
Francesco Siddi added 1 commit 2023-08-29 15:55:02 +02:00
Francesco Siddi added 4 commits 2023-08-30 02:21:56 +02:00
Sebastian Parborg commented 2023-08-30 09:11:12 +02:00
Author
Member
Copy Link

#!/usr/bin/env python3.11

Don't hard code the python version like this unless there is a very good reason to do so.

Now you have made it so those scripts will only run if the python version on the computer is exactly 3.11, which doesn't seem to be your intention as you already added a "version < 3.11" check and not "version == 3.11".

If the system default python3 version is less than the required version, then you can still run the scripts by doing python3.11 ./script.py. (Or you can also solve this by changing the default python3 version that is used on the system)

We can and probably should instead look and see if the 3.11 specific features can't be written in a more backwards compatible way so we can run it with python 3.10 or older if this is a bigger problem.

> #!/usr/bin/env python3.11 Don't hard code the python version like this unless there is a *very* good reason to do so. Now you have made it so those scripts will only run if the python version on the computer is exactly 3.11, which doesn't seem to be your intention as you already added a "version < 3.11" check and not "version == 3.11". If the system default python3 version is less than the required version, then you can still run the scripts by doing `python3.11 ./script.py`. (Or you can also solve this by changing the default python3 version that is used on the system) We can and probably should instead look and see if the 3.11 specific features can't be written in a more backwards compatible way so we can run it with python 3.10 or older if this is a bigger problem.
Sebastian Parborg commented 2023-08-30 09:21:25 +02:00
Author
Member
Copy Link

Also, thank you for working on this while I am gone! :)
I really appreciate it!

I guess we try to tackle the addon downloading together when I'm back?

Also, thank you for working on this while I am gone! :) I really appreciate it! I guess we try to tackle the addon downloading together when I'm back?
Francesco Siddi commented 2023-08-30 11:24:22 +02:00
Owner
Copy Link

Indeed the problem is that those two scripts strictly require Python 3.11. I can look into using a different method for more general compatibility. I'd like to get this merged today.

Indeed the problem is that those two scripts strictly require Python 3.11. I can look into using a different method for more general compatibility. I'd like to get this merged today.
Francesco Siddi added 2 commits 2023-08-31 20:06:22 +02:00
Francesco Siddi added 1 commit 2023-08-31 20:08:15 +02:00
Francesco Siddi changed title from WIP: project-helper-tools to Add project-tools 2023-08-31 20:08:48 +02:00
Francesco Siddi commented 2023-08-31 20:17:16 +02:00
Owner
Copy Link

I removed the requirement about Python 3.11. We can assume that it will be the min Python version. Overall this still needs some work, but it can be done in main.

I removed the requirement about Python 3.11. We can assume that it will be the min Python version. Overall this still needs some work, but it can be done in main.
Francesco Siddi merged commit 863210900d into main 2023-08-31 20:33:04 +02:00
Francesco Siddi deleted branch project-helper-tools 2023-08-31 20:33:59 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#142
No description provided.
Delete Branch "ZedDB/blender-studio-pipeline:project-helper-tools"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?