studio/blender-studio-tools
13
32
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

[Blender_Kitsu] Playblast shot with user viewport settings #11

Merged
Nick Alberelli merged 4 commits from :feature/playblast-shot-user-settings into master 2023-04-18 15:41:34 +02:00
Conversation 0 Commits 4 Files Changed 2 +106 -82
Nick Alberelli commented 2023-04-17 18:42:58 +02:00
Member
Copy Link

Closes: TinyNick/blender-studio-tools#25

Issue

When using plyblast, shading settings are always overriden to playblast defaults, which conflicts with the pet projects shading settings.

Solution

Add option to pass user viewport shading settings to payblast instead

UI Update

image

What's Changed

  • Refactor to make changing render settings easier in future
  • Added option to pass viewport shading duriing playblast
  • Set above option to True as default
  • Fix issue where playblast rendered overlays if they weren't hidden by user

Before

User shading settings are not rendered, some gizmos are visable in render
image

After

User shading settings are now rendered, no gizmos are visable in render
image

Closes: https://projects.blender.org/TinyNick/blender-studio-tools/issues/25 # Issue When using plyblast, shading settings are always overriden to playblast defaults, which conflicts with the pet projects shading settings. # Solution Add option to pass user viewport shading settings to payblast instead ## UI Update ![image](/attachments/69c7da46-a7cf-4055-9194-54559bae279e) ### What's Changed - Refactor to make changing render settings easier in future - Added option to pass viewport shading duriing playblast - Set above option to True as default - Fix issue where playblast rendered overlays if they weren't hidden by user ## Before User shading settings are not rendered, some gizmos are visable in render ![image](/attachments/b412fd01-4bd0-45db-955c-274daebfd746) ## After User shading settings are now rendered, no gizmos are visable in render ![image](/attachments/78d9b133-637a-479e-81e6-2d1a1336dc95)
image.png
238 KiB
image.png
238 KiB
image.png
609 KiB
image.png
594 KiB
image.png
19 KiB
image.png
611 KiB
image.png
235 KiB
image.png image.png image.png image.png
Nick Alberelli force-pushed feature/playblast-shot-user-settings from 7a5d43fce3 to aabb672c54 2023-04-17 21:45:01 +02:00 Compare
Nick Alberelli force-pushed feature/playblast-shot-user-settings from aabb672c54 to a16d708721 2023-04-17 21:48:01 +02:00 Compare
Nick Alberelli changed title from [Blender_Kitsu] Playblast shot with user viewport settings to WIP: [Blender_Kitsu] Playblast shot with user viewport settings 2023-04-17 21:58:32 +02:00
Nick Alberelli force-pushed feature/playblast-shot-user-settings from 13dbba9821 to d38c4ea2f0 2023-04-17 22:32:13 +02:00 Compare
Nick Alberelli changed title from WIP: [Blender_Kitsu] Playblast shot with user viewport settings to [Blender_Kitsu] Playblast shot with user viewport settings 2023-04-17 22:33:08 +02:00
Nick Alberelli force-pushed feature/playblast-shot-user-settings from d38c4ea2f0 to 190505705a 2023-04-18 14:30:56 +02:00 Compare
Nick Alberelli merged commit 312e3ffebc into master 2023-04-18 15:41:34 +02:00
Nick Alberelli deleted branch feature/playblast-shot-user-settings 2023-04-18 15:41:34 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#11
No description provided.
Delete Branch ":feature/playblast-shot-user-settings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?