studio/blender-studio-tools
12
31
Fork 19
Code Issues 20 Pull Requests 4 Projects Releases 1 Activity

[Blender_Kitsu] Publish Edit: Filenames are incorrect #12

New Issue
Closed
opened 2023-04-17 23:02:16 +02:00 by Nick Alberelli · 1 comment
Nick Alberelli commented 2023-04-17 23:02:16 +02:00
Member
Copy Link

Issue

In this PR I made this note When making the new 'Publish VSE Edit to Kistu' #7

Current pet project edit .blend files use have a naming convention {project_name}_v{revision}.mp4 convention.

  • Operator use this convention: {project_name}_{edit-entry}_v{revision}.mp4
  • This new filename convention To avoid overwriting any exisiting files on the shared drive when rendering new revisions in case of a mismatch.
  • Include Kitsu revision in filename to help users understand what operator is doing
  • We know the file's revision number by checking the number of existing preview files on the server via /data/edits/{edit_id}/preview-files

Solution

Specifically this line To avoid overwriting any exisiting files on the shared drive when rendering new revisions in case of a mismatch. is not correct. Better to cancel operation if file exist to avoid overwrite.

revert the naming convention so using this tools is exactly the same as previous editorial exports for petsproject

TODO

  • Fix Naming Convention
  • Cancel Operation if file exists to avoid unexpected overwrites

(and do it before anyone tries the tool!) :)

# Issue In this PR I made this note When making the new 'Publish VSE Edit to Kistu' https://projects.blender.org/studio/blender-studio-tools/pulls/7 Current pet project edit .blend files use have a naming convention `{project_name}_v{revision}.mp4` convention. > - Operator use this convention: `{project_name}_{edit-entry}_v{revision}.mp4` > - This new filename convention To avoid overwriting any exisiting files on the shared drive when rendering new revisions in case of a mismatch. > - Include Kitsu revision in filename to help users understand what operator is doing > - We know the file's revision number by checking the number of existing preview files on the server via `/data/edits/{edit_id}/preview-files` # Solution Specifically this line `To avoid overwriting any exisiting files on the shared drive when rendering new revisions in case of a mismatch.` is not correct. Better to cancel operation if file exist to avoid overwrite. revert the naming convention so using this tools is exactly the same as previous editorial exports for petsproject # TODO - [ ] Fix Naming Convention - [ ] Cancel Operation if file exists to avoid unexpected overwrites (and do it before anyone tries the tool!) :)
Nick Alberelli commented 2023-04-17 23:15:11 +02:00
Author
Member
Copy Link

suppose to be here: TinyNick/blender-studio-tools#35

suppose to be here: https://projects.blender.org/TinyNick/blender-studio-tools/issues/35
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#12
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?