studio/blender-studio-tools
13
32
Fork 19
Code Issues 22 Pull Requests 4 Projects Releases 1 Activity

[Blender_Kitsu] Pub_Edit_Rev: Fix frame_start not found on server #14

Merged
Nick Alberelli merged 1 commits from :fix/publish-edit-revision-frame-start-optional into master 2023-04-18 03:37:46 +02:00
Conversation 0 Commits 1 Files Changed 1 +2 -1
Nick Alberelli commented 2023-04-17 23:21:59 +02:00
Member
Copy Link

Closes: TinyNick/blender-studio-tools#37

Issue

If Kitsu server doesn't contain frame_start key within Edit [Blender_Kitsu] returns following

Python: Traceback (most recent call last):
  File "C:\Users\{user}\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\blender_kitsu\sqe\ops.py", line 2463, in invoke
    self.frame_start = server_frame_start
  File "c:\Users\{user}\Blender-Studio\Development\Blender-Builds\blender-git\build_windows_x64_vc16_Release\bin\Release\3.6\scripts\modules\bpy_types.py", line 822, in __setattr__
    return setattr(properties, attr, value)
TypeError: bpy_struct: item.attr = val: KITSU_OT_vse_publish_edit_revision.frame_start expected an int type, not NoneType

Solution

  • Add check if server_frame_start is int before invoke
Closes: https://projects.blender.org/TinyNick/blender-studio-tools/issues/37 # Issue If Kitsu server doesn't contain `frame_start` key within Edit [Blender_Kitsu] returns following ```python Python: Traceback (most recent call last): File "C:\Users\{user}\AppData\Roaming\Blender Foundation\Blender\3.6\scripts\addons\blender_kitsu\sqe\ops.py", line 2463, in invoke self.frame_start = server_frame_start File "c:\Users\{user}\Blender-Studio\Development\Blender-Builds\blender-git\build_windows_x64_vc16_Release\bin\Release\3.6\scripts\modules\bpy_types.py", line 822, in __setattr__ return setattr(properties, attr, value) TypeError: bpy_struct: item.attr = val: KITSU_OT_vse_publish_edit_revision.frame_start expected an int type, not NoneType ``` # Solution - [x] Add check if `server_frame_start` is int before invoke
Nick Alberelli force-pushed fix/publish-edit-revision-frame-start-optional from 08fff75c42 to a159463184 2023-04-17 23:22:28 +02:00 Compare
Nick Alberelli changed title from WIP: [Blender_Kitsu] Pub_Edit_Rev: Fix frame_start not found on server to [Blender_Kitsu] Pub_Edit_Rev: Fix frame_start not found on server 2023-04-18 03:26:44 +02:00
Nick Alberelli changed title from [Blender_Kitsu] Pub_Edit_Rev: Fix frame_start not found on server to [Blender_Kitsu] Pub_Edit_Rev: Fix `frame_start` not found on server 2023-04-18 03:27:05 +02:00
Nick Alberelli merged commit 0076748592 into master 2023-04-18 03:37:46 +02:00
Nick Alberelli deleted branch fix/publish-edit-revision-frame-start-optional 2023-04-18 03:37:46 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#14
No description provided.
Delete Branch ":fix/publish-edit-revision-frame-start-optional"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?