studio/blender-studio-tools
13
32
Fork 19
Code Issues 22 Pull Requests 4 Projects Releases 1 Activity

Clean Up Legacy Poetry Project Files #2

Merged
Nick Alberelli merged 13 commits from :fix/clean-up-addons into master 2023-03-23 21:21:36 +01:00
Conversation 2 Commits 13 Files Changed 32 -5925
Nick Alberelli commented 2023-03-22 20:51:10 +01:00
Member
Copy Link

Remove WIP AFTER #1 IS MERGED

Closes TinyNick/blender-studio-tools#20

Issue

Within each repo there are some project managment files like:

poetry.lock
pyproject.toml
mypy.ini
package.sh

These files are used to do project managment and deployment of addons. This is no longer necessary after #1 is merged.

Solution

Remove the above files from each addon if they are contained. Confirm no addons contain poetry project files.

TODO

  • anim-setup
  • asset-pipeline
  • blender-kitsu
  • blender-svn
  • cache-manager
  • contactsheet
  • grease-converter
  • pose-shape-keys
  • render-review
  • shot-builder
  • blender-media-viewer
  • blender-purge

Does not contain Poetry Files

  • bone-gizmos
  • freesound-credits
  • geonode-shapekeys
  • anim-cupboard
# ~~Remove WIP AFTER https://projects.blender.org/studio/blender-studio-tools/pulls/1 IS MERGED~~ Closes https://projects.blender.org/TinyNick/blender-studio-tools/issues/20 # Issue Within each repo there are some project managment files like: ``` poetry.lock pyproject.toml mypy.ini package.sh ``` These files are used to do project managment and deployment of addons. This is no longer necessary after https://projects.blender.org/studio/blender-studio-tools/pulls/1 is merged. # Solution Remove the above files from each addon if they are contained. Confirm no addons contain poetry project files. ### TODO - [x] anim-setup - [x] asset-pipeline - [x] blender-kitsu - [x] blender-svn - [x] cache-manager - [x] contactsheet - [x] grease-converter - [x] pose-shape-keys - [x] render-review - [x] shot-builder - [x] blender-media-viewer - [x] blender-purge ### Does not contain Poetry Files - bone-gizmos - freesound-credits - geonode-shapekeys - anim-cupboard
Nick Alberelli added 19 commits 2023-03-22 20:51:12 +01:00 
- Move addon to top level directory
 - Rename directory from Blender-Kitsu to Blender_Kitsu to preserve imports
- Blender_Kitsu imports depend on this
 - Renaming all Addons to Match this Style
- Blender_Kitsu imports depend on this "_" naming convention
 - Renaming all addons top level directories to match this style
- Blender_Kitsu imports depend on this "_" naming convention
 - Renaming all addons top level directories to match this style
- Move addon to top level directory
 - Rename directory from "-" to "_" convention
- Move addon to top level directory
 - Rename directory from Blender-Kitsu to Blender_Kitsu to preserve imports
- Move addon to top level directory
 - Rename directory from Blender-Kitsu to Blender_Kitsu to preserve imports
- Move addon to top level directory
- Move addon to top level directory
 - Rename directory from "-" to "_" convention
- Move addon to top level directory
 - Rename directory from "-" to "_" convention
- Move addon to top level directory
 - Rename directory from "-" to "_" convention
- Move addon to top level directory
 - Rename directory from "-" to "_" convention
- Move addon to top level directory
 - Rename directory from "-" to "_" convention
- Move addon to top level directory
 - Rename directory from "-" to "_" convention
This reverts commit b212c3f23b.
- /wheels/ was included in .gitignore file
 - removed from .gitignore file
Sebastian Parborg commented 2023-03-23 12:27:32 +01:00
Member
Copy Link

Seems like you removed the install.sh from the blender-purge project.
That script is not related to poetry.

Seems like you removed the `install.sh` from the `blender-purge` project. That script is not related to poetry.
Nick Alberelli commented 2023-03-23 14:06:47 +01:00
Author
Member
Copy Link

Seems like you removed the install.sh from the blender-purge project.
That script is not related to poetry.

@ZedDB Yes, that is my mistake. I have restored that file with this commit 896f68bc27

> Seems like you removed the `install.sh` from the `blender-purge` project. > That script is not related to poetry. @ZedDB Yes, that is my mistake. I have restored that file with this commit https://projects.blender.org/studio/blender-studio-tools/commit/896f68bc2701589844c9ef42ee61019752e9ad14
Nick Alberelli force-pushed fix/clean-up-addons from 896f68bc27 to a0d2613ccd 2023-03-23 16:17:19 +01:00 Compare
Nick Alberelli changed title from WIP: Clean Up Legacy Poetry Project Files to Clean Up Legacy Poetry Project Files 2023-03-23 16:20:31 +01:00
Sebastian Parborg requested review from Sebastian Parborg 2023-03-23 17:45:41 +01:00
Sebastian Parborg approved these changes 2023-03-23 17:46:26 +01:00
Sebastian Parborg left a comment
Member
Copy Link

LGTM, just remember to squash the commits before you merge this into master.

LGTM, just remember to squash the commits before you merge this into master.
Nick Alberelli merged commit 49cf4be52a into master 2023-03-23 21:21:36 +01:00
Nick Alberelli deleted branch fix/clean-up-addons 2023-03-23 21:21:36 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Sebastian Parborg
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#2
No description provided.
Delete Branch ":fix/clean-up-addons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?