studio/blender-studio-tools
13
32
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

Blender Kitsu: Asset Index code needs to be removed #333

New Issue
Closed
opened 2024-10-21 03:58:37 +02:00 by JM-15 · 2 comments
JM-15 commented 2024-10-21 03:58:37 +02:00
Contributor
Copy Link

System Information
Operating system: Linux

Blender Version: 4.2 LTS
Add-on Name & Version: Blender Kitsu v0.1.6

Short description of error

When the New Asset Tagging System was introduced, my understanding was that the asset_index.json was no longer necessary. However, if asset_index.json is missing when building a shot, it silently fails to import the shot's assets. The asset_index var populated here doesn't seem to be used, and I'm wondering if this is code that was overlooked and needs to be removed.

Exact steps for others to reproduce the error

Build a new shot with no asset_index.json file and assets configured correctly with collection and filepath columns in Kitsu, as well as shot breakdown configured correctly. Shot file will be generated with no linked assets and no logs indicating why. Adding an empty asset_index.json file is a workaround.

**System Information** Operating system: Linux Blender Version: 4.2 LTS Add-on Name & Version: Blender Kitsu v0.1.6 **Short description of error** When the [New Asset Tagging System was introduced](https://projects.blender.org/studio/blender-studio-pipeline/commit/ee7e3b9d8eb37a06a154d48dae933fcc23ff04e1), my understanding was that the `asset_index.json` was no longer necessary. However, if `asset_index.json` is missing when building a shot, it silently fails to import the shot's assets. The `asset_index` var populated [here]( https://projects.blender.org/studio/blender-studio-pipeline/src/branch/main/scripts-blender/addons/blender_kitsu/shot_builder/assets.py#L37) doesn't seem to be used, and I'm wondering if this is code that was overlooked and needs to be removed. **Exact steps for others to reproduce the error** Build a new shot with no `asset_index.json` file and assets configured correctly with collection and filepath columns in Kitsu, as well as shot breakdown configured correctly. Shot file will be generated with no linked assets and no logs indicating why. Adding an empty `asset_index.json` file is a workaround.
Francesco Siddi commented 2024-10-22 10:33:46 +02:00
Owner
Copy Link

Yes, the asset index should be removed. Could you help with this?

Yes, the asset index should be removed. Could you help with this?
JM-15 commented 2024-10-23 05:39:39 +02:00
Author
Contributor
Copy Link

@fsiddi, I tested and confirmed this was fixed in your recent commit. Thank you!

@fsiddi, I tested and confirmed this was fixed in [your recent commit](https://projects.blender.org/studio/blender-studio-pipeline/commit/33c4903deda61ca4a4bd95d7485f979038f4304c). Thank you!
JM-15 closed this issue 2024-10-23 05:39:40 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Kind
Breaking
Breaking change that won't be backward compatible

  
Kind
Bug
Something is not working

  
Kind: Community

Issues opened by members of the community / outside the studio

  
Kind
Documentation
Documentation changes

  
Kind
Easy
Simple to complete

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Proposal
A proposal or idea that requires feedback

  
Kind
Security
This is security issue

  
Kind
Studio Request
Requested by a user at the Blender-Studio

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind
Breaking
Kind
Bug
Kind: Community
Kind
Documentation
Kind
Easy
Kind
Enhancement
Kind
Feature
Kind
Proposal
Kind
Security
Kind
Studio Request
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/blender-studio-tools#333
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?