studio/blender-studio-tools
13
32
Fork 19
Code Issues 21 Pull Requests 4 Projects Releases 1 Activity

AnimCupboard: ID Management Pie #127

Merged
Demeter Dzadik merged 11 commits from Mets/blender-studio-pipeline:AnimCupboard-relationship-viewer into main 2023-07-19 14:43:14 +02:00
Conversation 0 Commits 11 Files Changed 3 +1 -16
1 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1a245cc7c2 - Show all commits

17
scripts-blender/addons/anim_cupboard/operators/id_management_pie.py
View File

@ -289,26 +289,11 @@ class OUTLINER_OT_remap_users(bpy.types.Operator):
) )
def execute(self, context): def execute(self, context):
for area in context.screen.areas:
if area.type == 'VIEW_3D':
break
else:
self.report(
{'ERROR'}, "Error: This operation requires an Outliner to be present."
)
return {'CANCELLED'}
source_id = get_id(self.id_name_source, self.id_type, self.library_path_source) source_id = get_id(self.id_name_source, self.id_type, self.library_path_source)
Nick Alberelli commented 2023-07-18 18:15:20 +02:00
Outdated
Review
Copy Link

This loop is looking for a VIEW_3D but the report says it is checking if an outliner is present. Assuming the outliner is what you are looking for wouldn't it be more explicit to do...

for area in context.screen.areas:
    if area.type == 'OUTLINER':
        break
else:
    self.report(
        {'ERROR'}, "Error: This operation requires an Outliner to be present."
    )
    return {'CANCELLED'}
This loop is looking for a `VIEW_3D` but the report says it is checking if an outliner is present. Assuming the outliner is what you are looking for wouldn't it be more explicit to do... ```python for area in context.screen.areas: if area.type == 'OUTLINER': break else: self.report( {'ERROR'}, "Error: This operation requires an Outliner to be present." ) return {'CANCELLED'} ```
target_id = get_id(self.id_name_target, self.id_type, self.library_path) target_id = get_id(self.id_name_target, self.id_type, self.library_path)
if not target_id: assert source_id and target_id, "Error: Failed to find source or target."
self.report(
{'ERROR'},
f'Failed to find ID: {self.id_name_target}, {self.id_type}, lib: {self.library_path}',
)
return {'CANCELLED'}
source_id.user_remap(target_id) source_id.user_remap(target_id)
return {'FINISHED'} return {'FINISHED'}