When using box select in the VSE, all marker lines get highlighted #57977

New Issue

Hjalti Hjálmarsson · 2018-11-21T15:19:58+01:00

2018-11-21 15:19:58 +01:00

System Information
Xbuntu / AMD

Blender Version
e85aa8b

Short description of error
When working in the VSE, if you use box selection (B) all the marker lines get highlighter (turn white)

Exact steps for others to reproduce the error
New file
Go to the VSE
Create a few markers
Do box selection in the VSE (even though there's nothing in it)
...all the marker lines become highlighted...

**System Information** Xbuntu / AMD **Blender Version** e85aa8b **Short description of error** When working in the VSE, if you use box selection (B) all the marker lines get highlighter (turn white) **Exact steps for others to reproduce the error** New file Go to the VSE Create a few markers Do box selection in the VSE (even though there's nothing in it) ...all the marker lines become highlighted...

Hjalti Hjálmarsson commented

2018-11-21 15:19:58 +01:00

Added subscriber: @Hjalti

Philipp Oeser commented

2018-11-22 12:51:08 +01:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2018-11-22 12:51:08 +01:00

Philipp Oeser commented

2018-11-22 12:51:08 +01:00

Confirmed, checking...

Philipp Oeser removed their assignment 2018-11-22 15:53:19 +01:00

Clément Foucault was assigned by Philipp Oeser

2018-11-22 15:53:19 +01:00

Philipp Oeser commented

2018-11-22 15:53:19 +01:00

Added subscriber: @fclem

Philipp Oeser commented

2018-11-22 15:53:19 +01:00

Note1: this goes away on a redraw (when panning the view)

Note2: drawing the marker lines ( [draw_marker() ]] ) seems to interfere with [ https:*developer.blender.org/diffusion/B/browse/blender2.8/source/blender/windowmanager/intern/wm_gesture.c;e815784aa684ccd66a491bbf27370b91ce14f397$193 | wm_gesture_draw_rect()
(e.g. I can change the color for the gesture border and the 'highlighted' marker lines described in the report appear in the same color)

Somehow the one programm (gesture border) is not finished correctly?

both use immBindBuiltinProgram(GPU_SHADER_2D_LINE_DASHED_UNIFORM_COLOR)
both have a block with immBegin and immEnd
both do immUnbindProgram()

Not sure whats going on, would like to hand this off to @fclem... [or maybe he could tell me a way to debug this properly...]

Note1: this goes away on a redraw (when panning the view) Note2: drawing the marker lines ( [`draw_marker()` ]] ) seems to interfere with [[ https:*developer.blender.org/diffusion/B/browse/blender2.8/source/blender/windowmanager/intern/wm_gesture.c;e815784aa684ccd66a491bbf27370b91ce14f397$193 | `wm_gesture_draw_rect()`](https:*developer.blender.org/diffusion/B/browse/blender2.8/source/blender/editors/animation/anim_markers.c;e815784aa684ccd66a491bbf27370b91ce14f397$381) (e.g. I can change the color for the gesture border and the 'highlighted' marker lines described in the report appear in the same color) Somehow the one programm (gesture border) is not finished correctly? - both use `immBindBuiltinProgram(GPU_SHADER_2D_LINE_DASHED_UNIFORM_COLOR)` - both have a block with `immBegin` and `immEnd` - both do `immUnbindProgram()` Not sure whats going on, would like to hand this off to @fclem... [or maybe he could tell me a way to debug this properly...]

blender-admin commented

2018-11-22 16:13:18 +01:00

This issue was referenced by blender/blender@3280adc0aa

This issue was referenced by blender/blender@3280adc0aa31ad5bccd35ef02da6a48c37b3fbde

Clément Foucault commented

2018-11-22 16:15:29 +01:00

Changed status from 'Open' to: 'Resolved'

Clément Foucault closed this issue

2018-11-22 16:15:29 +01:00

Clément Foucault commented

2018-11-22 16:17:05 +01:00

@lichtwerk This is because wm_gesture_draw_rect change a uniform and uniform values are stored inside the shader. So if the next time the shader is used the uniform is not set to the desired value, it will use the previous one.

Sign in to join this conversation.