studio/blender-studio
3
4
Fork 4
Code Issues 36 Pull Requests 2 Projects 1 Releases 5 Wiki Activity

UI: Training templates fluid video layouts #104435

Merged
Márton Lente merged 13 commits from ui/training-layout-fluid into main 2024-08-23 16:50:27 +02:00
Conversation 2 Commits 13 Files Changed 7 +6 -5
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a4afcc65c8 - Show all commits

11
training/templates/training/training.html
View File

@ -16,15 +16,16 @@
<section class="training-group-item training-group-item-content-detail"> <section class="training-group-item training-group-item-content-detail">
<div class="row training-group-item-content-detail-inner"> <div class="row training-group-item-content-detail-inner">
<div class="col"> <div class="col">
<div class="mb-3 row"> {% if training.picture_header_url %}
martonlente marked this conversation as resolved Outdated
Pablo Vazquez commented 2024-08-23 16:13:25 +02:00
Outdated
Review
Copy Link

This entire div can be empty if {% if training.picture_header_url %} is false.
Adding a gap because of mb-3 without anything inside.

Move the check up here.

This entire div can be empty if `{% if training.picture_header_url %}` is false. Adding a gap because of `mb-3` without anything inside. Move the check up here.
Márton Lente commented 2024-08-23 16:28:52 +02:00
Outdated
Review
Copy Link

Thanks, it has been fixed.

Thanks, it has been fixed.
<div class="col"> <div class="mb-3 row">
{% if training.picture_header_url %} <div class="col">
<div class="training-header-img-helper"> <div class="training-header-img-helper">
<img src="{{ training.picture_header_url }}" class="img-fluid img-width-100 rounded" alt="{{ training.name }}"> <img src="{{ training.picture_header_url }}" class="img-fluid img-width-100 rounded" alt="{{ training.name }}">
</div> </div>
{% endif %} </div>
</div> </div>
</div> {% endif %}
<div class="align-items-start mb-3 row"> <div class="align-items-start mb-3 row">
<div class="col-12 col-md"> <div class="col-12 col-md">
<h1 class="mb-0">{{ training.name }}</h1> <h1 class="mb-0">{{ training.name }}</h1>