Shaman unit test TestGarbageCollect is unstable #104218

New Issue

Sybren A. Stüvel · 2023-05-31T12:08:45+02:00

Sybren A. Stüvel commented

2023-05-31 12:08:45 +02:00

System Information
Operating System(s): Windows 10, but seen on Linux as well

Flamenco Version
Is Broken: Flamenco 3.3-alpha (16da14479bf5bd11a585f0941f9adeb4d5301190); likely all 3.x releases.
Worked OK: Not sure if this ever worked 100%

Short description of error

The Shaman TestGarbageCollect unit test sometimes fails.

Exact steps for others to reproduce the error

$ go test ./pkg/shaman/... -test.count 1

If this doesn't trigger the error, repeat until it does. The -test.count 1 forces the test to be re-run (instead of caching the result).

The error:

--- FAIL: TestGarbageCollect (0.04s)
    cleanup_test.go:220:
                Error Trace:    cleanup_test.go:220
                Error:          Should be true
                Test:           TestGarbageCollect
                Messages:       file C:\Users\Sybren\AppData\Local\Temp\shaman-test-2921007643\file-store\stored\30\928ffced04c7008f3324fded86d133effea50828f5ad896196f2a2e190ac7e\6001.blob should NOT exist 
after GC

**System Information** Operating System(s): Windows 10, but seen on Linux as well **Flamenco Version** Is Broken: Flamenco 3.3-alpha (`16da14479bf5bd11a585f0941f9adeb4d5301190`); likely all 3.x releases. Worked OK: Not sure if this ever worked 100% **Short description of error** The Shaman `TestGarbageCollect` unit test sometimes fails. **Exact steps for others to reproduce the error** ```bash $ go test ./pkg/shaman/... -test.count 1 ``` If this doesn't trigger the error, repeat until it does. The `-test.count 1` forces the test to be re-run (instead of caching the result). The error: ``` --- FAIL: TestGarbageCollect (0.04s) cleanup_test.go:220: Error Trace: cleanup_test.go:220 Error: Should be true Test: TestGarbageCollect Messages: file C:\Users\Sybren\AppData\Local\Temp\shaman-test-2921007643\file-store\stored\30\928ffced04c7008f3324fded86d133effea50828f5ad896196f2a2e190ac7e\6001.blob should NOT exist after GC ```

Sybren A. Stüvel referenced this issue

2023-05-31 12:09:32 +02:00

Fix #99549: Remember Previous Status #104217

Sybren A. Stüvel referenced this issue from a commit

2023-05-31 13:59:02 +02:00

Shaman: improve logging & checking of timestamps

Sybren A. Stüvel referenced this issue from a commit

2023-05-31 13:59:02 +02:00

Fix #104218: Shaman unit test TestGarbageCollect is unstable

Sybren A. Stüvel closed this issue

2023-05-31 14:05:33 +02:00

Sign in to join this conversation.