Manager: handle inconsistent trailing path separator in two-way variables #104293

New Issue

Sybren A. Stüvel · 2024-03-28T12:33:12+01:00

Sybren A. Stüvel commented

2024-03-28 12:33:12 +01:00

With a configuration like this, the path replacement may go wrong, as one path ends in a path separator and others don't:

variables:
  my_storage:
    is_twoway: true
    values:
    - platform: linux
      value: /media/shared
    - platform: windows
      value: F:\
    - platform: darwin
      value: /Volumes/shared

Two approaches to adress this come to mind:

Warn when the configuration is inconsistent
Assume that only entire paths are to be replaced (so the above should not replace /Volumes/shared-drive with {my_storage}-drive) so the trailing path separator can be appended implicitly.

The last one is preferred, as it doesn't require the user to update their configuration.

With a configuration like this, the path replacement may go wrong, as one path ends in a path separator and others don't: ```yaml variables: my_storage: is_twoway: true values: - platform: linux value: /media/shared - platform: windows value: F:\ - platform: darwin value: /Volumes/shared ``` Two approaches to adress this come to mind: 1. Warn when the configuration is inconsistent 2. Assume that only entire paths are to be replaced (so the above should not replace `/Volumes/shared-drive` with `{my_storage}-drive`) so the trailing path separator can be appended implicitly. The last one is preferred, as it doesn't require the user to update their configuration.

Sign in to join this conversation.