studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

SQLite: Foreign key constraints can be disabled #104305

New Issue
Closed
opened 2024-05-10 12:03:42 +02:00 by Sybren A. Stüvel · 1 comment
Sybren A. Stüvel commented 2024-05-10 12:03:42 +02:00
Owner
Copy Link

Flamenco Version
Is Broken: 3.5 and older 3.x releases
Worked OK: never

Short description of error
When the Flamenco process is running for long enough, it seems that GORM can close the sqlite connection and create a new one by itself. Since that then doesn't execute the PRAGMA SQL commands to enable foreign key constraints, these constraints are disabled on this new connection. The result is that deleting a job will not delete its tasks, and same for other deletion operations.

Exact steps for others to reproduce the error
This is hard to reproduce, as it includes (for me) unknown GORM behaviour.

  1. Run Flamenco Manager for long enough.
  2. Delete a job.

Solution
Replace GORM with something that either provides an on-connect callback function, or doesn't reconnect by itself. Work is already underway to replace GORM with sqlc in #104304.

Note that there are already some guards in place, that refuse to delete jobs / workers / tags when foreign key constraints are disabled.

**Flamenco Version** Is Broken: 3.5 and older 3.x releases Worked OK: never **Short description of error** When the Flamenco process is running for long enough, it seems that GORM can close the sqlite connection and create a new one by itself. Since that then doesn't execute the `PRAGMA` SQL commands to enable foreign key constraints, these constraints are disabled on this new connection. The result is that deleting a job will not delete its tasks, and same for other deletion operations. **Exact steps for others to reproduce the error** This is hard to reproduce, as it includes (for me) unknown GORM behaviour. 1. Run Flamenco Manager for long enough. 2. Delete a job. **Solution** Replace GORM with something that either provides an on-connect callback function, or doesn't reconnect by itself. Work is already underway to replace GORM with [sqlc](https://sqlc.dev/) in #104304. Note that there are already some guards in place, that refuse to delete jobs / workers / tags when foreign key constraints are disabled.
Sybren A. Stüvel added the
Priority
High
 label 2024-05-10 12:03:50 +02:00
Sybren A. Stüvel added the
Type
Bug
 label 2024-05-16 12:15:54 +02:00
Sybren A. Stüvel self-assigned this 2024-06-19 15:56:26 +02:00
Francesco Siddi commented 2024-09-28 13:24:29 +02:00
Owner
Copy Link

🥇

🥇
🎉 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Job Type
Custom Flamenco job type

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Sybren A. Stüvel
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#104305
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?