studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Flamenco-Manager: Upgrade acme/autocert library #71444

New Issue
Closed
opened 2019-11-09 13:16:50 +01:00 by Francesco Siddi · 4 comments
Francesco Siddi commented 2019-11-09 13:16:50 +01:00
Owner
Copy Link

Since November 2019 ACMEv1 is not allowed for new account registrations.

This seems to be reflected by the flamenco-manager logs when making a new deploy:

Nov 09 11:39:39 flame5 flamenco-manager[4390]: time="2019-11-09T11:39:39Z" level=info msg="creating ACME/Let's Encrypt enabled server" acme_domain_name=flame5.northeurope.cloudapp.azure.com listen=":8080" listen_https=":8443"
Nov 09 11:39:46 flame5 flamenco-manager[4390]: 2019/11/09 11:39:46 http: TLS handshake error from 213.127.23.167:35675: 403 urn:acme:error:unauthorized: Account creation on ACMEv1 is disabled. Please upgrade your ACME client to a version that supports ACM
Nov 09 11:40:10 flame5 flamenco-manager[4390]: 2019/11/09 11:40:10 http: TLS handshake error from 213.127.23.167:35736: acme/autocert: missing certificate
Nov 09 11:40:12 flame5 flamenco-manager[4390]: 2019/11/09 11:40:12 http: TLS handshake error from 213.127.23.167:35679: acme/autocert: missing certificate

Could you please look into upgrading the library? I tried go get -u golang.org/x/crypto/acme/autocert but i'm not sure if that is sufficient.

Since November 2019 [ACMEv1 is not allowed](https://community.letsencrypt.org/t/end-of-life-plan-for-acmev1/88430) for new account registrations. This seems to be reflected by the flamenco-manager logs when making a new deploy: ``` Nov 09 11:39:39 flame5 flamenco-manager[4390]: time="2019-11-09T11:39:39Z" level=info msg="creating ACME/Let's Encrypt enabled server" acme_domain_name=flame5.northeurope.cloudapp.azure.com listen=":8080" listen_https=":8443" Nov 09 11:39:46 flame5 flamenco-manager[4390]: 2019/11/09 11:39:46 http: TLS handshake error from 213.127.23.167:35675: 403 urn:acme:error:unauthorized: Account creation on ACMEv1 is disabled. Please upgrade your ACME client to a version that supports ACM Nov 09 11:40:10 flame5 flamenco-manager[4390]: 2019/11/09 11:40:10 http: TLS handshake error from 213.127.23.167:35736: acme/autocert: missing certificate Nov 09 11:40:12 flame5 flamenco-manager[4390]: 2019/11/09 11:40:12 http: TLS handshake error from 213.127.23.167:35679: acme/autocert: missing certificate ``` Could you please look into upgrading the library? I tried `go get -u golang.org/x/crypto/acme/autocert` but i'm not sure if that is sufficient.
Sybren A. Stüvel was assigned by Francesco Siddi 2019-11-09 13:16:50 +01:00
Francesco Siddi commented 2019-11-09 13:16:50 +01:00
Author
Owner
Copy Link

Added subscriber: @fsiddi

Added subscriber: @fsiddi
Sybren A. Stüvel commented 2019-11-12 12:50:30 +01:00
Owner
Copy Link

The package is golang.org/x/crypto (see the entry in go.mod), so go get -u golang.org/x/crypto + make would have been sufficient.

The package is `golang.org/x/crypto` (see the entry in `go.mod`), so `go get -u golang.org/x/crypto` + `make` would have been sufficient.
blender-admin commented 2019-11-12 12:51:11 +01:00
Copy Link

This issue was referenced by archive/flamenco-manager@5424fce794

This issue was referenced by archive/flamenco-manager@5424fce7945007dd88a71e2e6da6450d205d535e
Sybren A. Stüvel commented 2019-11-12 12:51:57 +01:00
Owner
Copy Link

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Job Type
Custom Flamenco job type

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Sybren A. Stüvel
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#71444
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?