Make tables respect the window height #99391

New Issue

Sybren A. Stüvel · 2022-07-04T14:24:59+02:00

Sybren A. Stüvel commented

2022-07-04 14:24:59 +02:00

The tables in the webapp are made with Tabulator. Tabulator needs a fixed height setting in order to enable the "virtual DOM" approach, which in turn is necessary to keep the tables fast with thousands of items in there. This fixed height needs to be adjusted with the right CSS/JavaScript combo to respond to changes in available space.

The available vertical space can change due to:

window resizing,
changes in contents above the tables, for example:
- when navigating jobs, the job details component can change in height to accomodate different settings/metadata,
- when available statuses change, the filter bar can appear or disappear.
change in contents below the tables (for example a future change in the notifications pop-over, which then might push the table upwards when opened).
- Jobs table
- Tasks table
- Workers table

The tables in the webapp are made with [Tabulator](http://tabulator.info/). Tabulator needs a fixed `height` setting in order to enable the "virtual DOM" approach, which in turn is necessary to keep the tables fast with thousands of items in there. This fixed height needs to be adjusted with the right CSS/JavaScript combo to respond to changes in available space. The available vertical space can change due to: - window resizing, - changes in contents above the tables, for example: - when navigating jobs, the job details component can change in height to accomodate different settings/metadata, - when available statuses change, the filter bar can appear or disappear. - change in contents below the tables (for example a future change in the notifications pop-over, which then might push the table upwards when opened). - - [x] Jobs table - - [x] Tasks table - - [x] Workers table

Sybren A. Stüvel commented

2022-07-04 14:24:59 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sybren A. Stüvel commented

2022-07-04 14:24:59 +02:00

Added subscriber: @dr.sybren

Pablo Vazquez was assigned by Sybren A. Stüvel

2022-07-05 17:25:51 +02:00

Pablo Vazquez commented

2022-07-07 15:45:42 +02:00

With the latest fixes it should work now (at least as of 23e752b3).

Tested on Chrome 102.0.5005.115 and Firefox 101.0.1

If more people can confirm we can close this.

With the latest fixes it should work now (at least as of 23e752b3). Tested on Chrome 102.0.5005.115 and Firefox 101.0.1 If more people can confirm we can close this.

Sybren A. Stüvel commented

2022-07-07 15:48:46 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2022-07-07 15:48:46 +02:00

Sybren A. Stüvel commented

2022-07-07 15:48:46 +02:00

👍 LGTM!

:+1: LGTM!

Sybren A. Stüvel commented

2022-07-07 16:16:06 +02:00

Changed status from 'Resolved' to: 'Confirmed'

Sybren A. Stüvel reopened this issue

2022-07-07 16:16:06 +02:00

Sybren A. Stüvel commented

2022-07-07 16:16:06 +02:00

There's still the "little scrollbar" issue. This time I think it happened after a new job was created. This was with Firefox 102.0.

recording-2022-07-07_16.13.32.mp4

There's still the "little scrollbar" issue. This time I think it happened after a new job was created. This was with Firefox 102.0. [recording-2022-07-07_16.13.32.mp4](https://archive.blender.org/developer/F13265578/recording-2022-07-07_16.13.32.mp4)

Pablo Vazquez commented

2022-07-07 16:21:30 +02:00

Tested on 102.0, added a new job but can't reproduce so far.

sc_-2022-07-07_16.25.17.mp4

If you can find what triggers it please post it here.

Tested on 102.0, added a new job but can't reproduce so far. [sc_-2022-07-07_16.25.17.mp4](https://archive.blender.org/developer/F13265593/sc_-2022-07-07_16.25.17.mp4) If you can find what triggers it please post it here.

Pablo Vazquez was unassigned by Sybren A. Stüvel

2022-07-16 10:47:12 +02:00

Sybren A. Stüvel self-assigned this 2022-07-16 10:47:12 +02:00

Sybren A. Stüvel commented

2022-07-16 10:47:12 +02:00

Added subscriber: @pablovazquez

Sybren A. Stüvel commented

2022-07-16 10:48:58 +02:00

I think I have it solved. If it shows up anyway, we can always file a new bug report.

My way to get things working (I wouldn't call this a "solution" as I don't know the root cause) was to emit two consecutive "reshuffled" events when changing tabs in the job details, and to recalculate the table height when the job type (so not the job itself, but its type info) is loaded.

I think I have it solved. If it shows up anyway, we can always file a new bug report. My way to get things working (I wouldn't call this a "solution" as I don't know the root cause) was to emit two consecutive "reshuffled" events when changing tabs in the job details, and to recalculate the table height when the job type (so not the job itself, but its type info) is loaded.

Sybren A. Stüvel commented

2022-07-16 10:49:47 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2022-07-16 10:49:47 +02:00

blender-admin commented

2022-07-16 10:51:43 +02:00

This issue was referenced by 9cebcc9f7c

This issue was referenced by 9cebcc9f7cf9db44b9ee86a566e5672265717e6c

Sybren A. Stüvel commented

2022-07-16 10:52:04 +02:00

For the record, the way I could reproduce the issue was in two ways:

Switch between jobs with different render_output_path lengths, one that doesn't line-wrap and one that does.
Flip through the Job Settings, Metadata, and Details tabs.

For the record, the way I could reproduce the issue was in two ways: - Switch between jobs with different `render_output_path` lengths, one that doesn't line-wrap and one that does. - Flip through the Job Settings, Metadata, and Details tabs.

Sign in to join this conversation.