studio/flamenco
studio
/
flamenco
12
27
Fork 32
Code Issues 60 Pull Requests 7 Releases Wiki Activity

Support deleting jobs, with Shaman checkout dir #99401

New Issue
Closed
opened 2022-07-04 14:51:09 +02:00 by Sybren A. Stüvel · 6 comments
Sybren A. Stüvel commented 2022-07-04 14:51:09 +02:00
Owner
Copy Link

Support deleting jobs from the web interface.

    • When submitting new job via Shaman, store the checkout ID in the job's database entry, for reliable removal afterwards. (014c0d3b3d and f413a40f4e)
    • Deleting a job (via the API) should delete: (23afbfbea2 and 791d877ff1)
      • all its related entries in the database, such as tasks, blocklists, task dependencies, etc.
      • task log files
      • last-rendered images
      • maybe also the parent of the job-specific storage directory, f.e. after removing flamenco-manager-storage/job-ce2e/ce2eb26b-cce0-4db3-bcdd-98c91361b68f maybe flamenco-manager-storage/job-ce2e is empty and should be removed too
      • Shaman checkout directory (i.e. the files that were submitted for this job). Shaman has its own garbage collection system, so any files that are now unused after job deletion will be cleaned up a number of days later.
    • Web interface:
      • Some way to request job deletion
      • Showing "deletion requested" jobs in a different way.
    • SocketIO updates:
      • job deletion was requested
      • job deletion completed

Work has started in the job-deletion-#99401 branch.

Support deleting jobs from the web interface. - - [x] When submitting new job via Shaman, store the checkout ID in the job's database entry, for reliable removal afterwards. (014c0d3b3d and f413a40f4e) - - [x] Deleting a job (via the API) should delete: (23afbfbea2 and 791d877ff1) - - [x] all its related entries in the database, such as tasks, blocklists, task dependencies, etc. - - [x] task log files - - [x] last-rendered images - - [x] maybe also the parent of the job-specific storage directory, f.e. after removing `flamenco-manager-storage/job-ce2e/ce2eb26b-cce0-4db3-bcdd-98c91361b68f` maybe `flamenco-manager-storage/job-ce2e` is empty and should be removed too - - [x] Shaman checkout directory (i.e. the files that were submitted for this job). Shaman has its own garbage collection system, so any files that are now unused after job deletion will be cleaned up a number of days later. - - [x] Web interface: - - [x] Some way to request job deletion - - [x] Showing "deletion requested" jobs in a different way. - - [x] SocketIO updates: - - [x] job deletion was requested - - [x] job deletion completed Work has started in the [job-deletion-#99401](https://developer.blender.org/diffusion/F/history/job-deletion-#99401/) branch.
Sybren A. Stüvel commented 2022-07-04 14:51:09 +02:00
Author
Owner
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Sybren A. Stüvel commented 2022-07-04 14:51:09 +02:00
Author
Owner
Copy Link

Added subscriber: @dr.sybren

Added subscriber: @dr.sybren
blender-admin commented 2022-12-14 17:17:18 +01:00
Copy Link

This issue was referenced by 638023dfc80477beff996460727f9bbcfd4b5984

This issue was referenced by 638023dfc80477beff996460727f9bbcfd4b5984
blender-admin commented 2023-01-05 23:23:02 +01:00
Copy Link

This issue was referenced by ef3cab9745

This issue was referenced by ef3cab974557cc440ef674fb9c54158e874714b1
Sybren A. Stüvel changed title from Support deleting jobs to Support deleting jobs, with Shaman checkout dir 2023-01-18 16:11:52 +01:00
Sybren A. Stüvel self-assigned this 2023-01-20 14:01:42 +01:00
Sybren A. Stüvel removed their assignment 2023-01-20 14:01:59 +01:00
Francesco Siddi was assigned by Sybren A. Stüvel 2023-01-20 14:01:59 +01:00
Francesco Siddi was unassigned by Sybren A. Stüvel 2023-01-20 14:02:05 +01:00
Sybren A. Stüvel commented 2023-01-20 14:02:05 +01:00
Author
Owner
Copy Link

Added subscriber: @fsiddi

Added subscriber: @fsiddi
Francesco Siddi was assigned by Sybren A. Stüvel 2023-01-20 14:02:16 +01:00
Francesco Siddi was unassigned by Sybren A. Stüvel 2023-01-20 14:02:56 +01:00
Sybren A. Stüvel self-assigned this 2023-01-20 14:02:56 +01:00
Sybren A. Stüvel commented 2023-02-03 16:59:45 +01:00
Author
Owner
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
blender-hq-farm
magefile
mdns-test
bcon-2023
windows-symlinks
siggraph-2023
T99441-stay-awake
flamenco-v2-server
production
cryptography-rust-fix
v3.5
v3.4
v3.3.1
v3.3
v3.3-beta3
v3.3-beta2
v3.3-beta1
v3.2
v3.1
v3.0
v3.0-beta3
v3.0-beta2
v3.0-beta1
v2.2
v2.1
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v2.0
last-py27
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Sybren A. Stüvel
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#99401
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?