Worker: refactor, remove doneChan field from Worker struct #99414

New Issue

Sybren A. Stüvel · 2022-07-04T15:29:14+02:00

Sybren A. Stüvel commented

2022-07-04 15:29:14 +02:00

Remove doneChan field from Worker struct, and the handling of that field. Its intended use overlaps with the global context.Context, and thus only one of the two needs to be kept.

Remove `doneChan` field from `Worker` struct, and the handling of that field. Its intended use overlaps with the global `context.Context`, and thus only one of the two needs to be kept.

Sybren A. Stüvel commented

2022-07-04 15:29:14 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sybren A. Stüvel commented

2022-07-04 15:29:14 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2022-07-19 15:26:12 +02:00

Changed status from 'Confirmed' to: 'Archived'

Sybren A. Stüvel closed this issue

2022-07-19 15:26:12 +02:00

Sybren A. Stüvel commented

2022-07-19 15:26:12 +02:00

Archiving this task as it doesn't paint the entire picture.
As the Worker changes state, it spawns a new goroutine for that state, then ends the current one. This means there is not a single loop that exits on shutdown, like the task description would suggest.

Archiving this task as it doesn't paint the entire picture. As the Worker changes state, it spawns a new goroutine for that state, then ends the current one. This means there is not a single loop that exits on shutdown, like the task description would suggest.

Sign in to join this conversation.