studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Sleep Scheduler: reconsider what happens when schedule is inactive #99886

New Issue
Open
opened 2022-07-21 12:48:37 +02:00 by Sybren A. Stüvel · 2 comments
Sybren A. Stüvel commented 2022-07-21 12:48:37 +02:00
Owner
Copy Link

At the moment, when a Worker has an inactive sleep schedue, the Sleep Scheduler will reply awake when queried for the desired Worker status. This behaviour could be seen as overstepping the responsibilities of the Sleep Scheduler.

It might be a better design to let the Sleep Scheduler return an empty string instead, indicating "I don't have anything to say about this Worker". Then the caller could make up its own mind about what to do with the Worker.

At the moment, when a Worker has an inactive sleep schedue, the Sleep Scheduler will reply `awake` when queried for the desired Worker status. This behaviour could be seen as overstepping the responsibilities of the Sleep Scheduler. It might be a better design to let the Sleep Scheduler return an empty string instead, indicating "I don't have anything to say about this Worker". Then the caller could make up its own mind about what to do with the Worker.
Sybren A. Stüvel commented 2022-07-21 12:48:37 +02:00
Author
Owner
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Sybren A. Stüvel commented 2022-07-21 12:48:37 +02:00
Author
Owner
Copy Link

Added subscriber: @dr.sybren

Added subscriber: @dr.sybren
Sybren A. Stüvel added
Type
Design
 and removed
Type
Report
 labels 2023-02-17 11:11:09 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Good First Issue
  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Job Type
Custom Flamenco job type

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: studio/flamenco#99886
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?