studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Account for the instance of submodules.pack.Packer #104184

Merged
Sybren A. Stüvel merged 5 commits from Nitin-Rawat-1/flamenco:104183-Error-submitting-job into main 2023-02-17 11:06:08 +01:00
Conversation 4 Commits 5 Files Changed 1 +5 -8
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0abf83b25b - Show all commits

13
addon/flamenco/bat/interface.py
View File

@ -165,14 +165,11 @@ class PackThread(threading.Thread):
log.debug("done")
self._set_bat_status("DONE")
if isinstance(self.packer, submodules.pack.Packer):
msg = MsgDone(self.packer.output_path, self.packer.missing_files)
else:
msg = MsgDone(
self.packer.output_path,
self.packer.missing_files,
self.packer.actual_checkout_path,
)
msg = MsgDone(
dr.sybren marked this conversation as resolved
Sybren A. Stüvel commented 2023-02-14 10:16:52 +01:00
Review
Copy Link

I think the code can be simplified to:

msg = MsgDone(
    self.packer.output_path,
    self.packer.missing_files,
    getattr(self.packer, 'actual_checkout_path', None),
)

That way the entire if can go away, and it's no longer specific to a particular Packer implementation.

I think the code can be simplified to: ```py msg = MsgDone( self.packer.output_path, self.packer.missing_files, getattr(self.packer, 'actual_checkout_path', None), ) ``` That way the entire `if` can go away, and it's no longer specific to a particular `Packer` implementation.
self.packer.output_path,
self.packer.missing_files,
getattr(self.packer, "actual_checkout_path", None),
)
self.queue.put(msg)
def _set_bat_status(self, status: str) -> None: