studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 4 Releases Wiki Activity

Account for the instance of submodules.pack.Packer #104184

Merged
Sybren A. Stüvel merged 5 commits from Nitin-Rawat-1/flamenco:104183-Error-submitting-job into main 2023-02-17 11:06:08 +01:00
Conversation 4 Commits 5 Files Changed 1 -2
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 518e5fc7ba - Show all commits

2
addon/flamenco/bat/interface.py
View File

@ -8,7 +8,6 @@ import logging
import queue import queue
import threading import threading
import typing import typing
import traceback
dr.sybren marked this conversation as resolved
Sybren A. Stüvel commented 2023-02-14 10:16:27 +01:00
Review
Copy Link

Please dont' include formatting changes. In general, cleanups of formatting (and other changes that don't alter the functionality) should be in a PR by themselves.

Please dont' include formatting changes. In general, cleanups of formatting (and other changes that don't alter the functionality) should be in a PR by themselves.
from . import submodules from . import submodules
log = logging.getLogger(__name__) log = logging.getLogger(__name__)
@ -149,7 +148,6 @@ class PackThread(threading.Thread):
except BaseException as ex: except BaseException as ex:
log.error("Error packing with BAT: %s", ex) log.error("Error packing with BAT: %s", ex)
self.queue.put(MsgException(ex=ex)) self.queue.put(MsgException(ex=ex))
traceback.print_exc()
finally: finally:
with _packer_lock: with _packer_lock:
_running_packthread = None _running_packthread = None