studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 64 Pull Requests 5 Releases Wiki Activity

WIP: 103268-job-task-progress #104185

Draft
Nitin-Rawat-1 wants to merge 19 commits from Nitin-Rawat-1/flamenco:103268-job-task-progress into main
pull from: Nitin-Rawat-1/flamenco:103268-job-task-progress
merge into: studio:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 0 Commits 19 Files Changed 30 +1 -2
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a25f82ea96 - Show all commits

3
internal/worker/command_exe.go
View File

@ -49,9 +49,8 @@ type TimeService interface {
Now() time.Time Now() time.Time
} }
// CommandLineRunner is an interface around exec.CommandContext().
//
//go:generate go run github.com/golang/mock/mockgen -destination mocks/cli_runner.gen.go -package mocks git.blender.org/flamenco/internal/worker CommandLineRunner //go:generate go run github.com/golang/mock/mockgen -destination mocks/cli_runner.gen.go -package mocks git.blender.org/flamenco/internal/worker CommandLineRunner
// CommandLineRunner is an interface around exec.CommandContext().
type CommandLineRunner interface { type CommandLineRunner interface {
Sybren A. Stüvel commented 2023-03-10 11:13:29 +01:00
Outdated
Review
Copy Link

Try to keep the changes in a PR to a minimum. Unless there is a good reason, keep the ordering of these comments the same. That'll make it easier to see what actually changed.

Try to keep the changes in a PR to a minimum. Unless there is a good reason, keep the ordering of these comments the same. That'll make it easier to see what actually changed.
CommandContext(ctx context.Context, name string, arg ...string) *exec.Cmd CommandContext(ctx context.Context, name string, arg ...string) *exec.Cmd
RunWithTextOutput( RunWithTextOutput(