studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Shaman: fail unit test when running as root user (linux) #104234

Manually merged
Sybren A. Stüvel merged 2 commits from michael-2/flamenco:mgr_api_meta_test_TestCheckSharedStoragePath into main 2023-07-07 16:07:17 +02:00
Conversation 1 Commits 2 Files Changed 1 +22 -17
1 changed files with 22 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e3a6522af6 - Show all commits

15
internal/manager/api_impl/meta_test.go
View File

@ -190,11 +190,16 @@ func TestCheckSharedStoragePath(t *testing.T) {
// that seems consistent. // that seems consistent.
// FIXME: find another way to test with unwritable directories on Windows. // FIXME: find another way to test with unwritable directories on Windows.
if runtime.GOOS != "windows" { if runtime.GOOS != "windows" {
currentUser, err := user.Current()
if err != nil { // Root can always create directories, so this test would fail with a
t.FailNow() // confusing message. Instead it's better to refuse running as root at all.
} else if currentUser.Username != "root" { currentUser, err := user.Current()
require.NoError(t, err)
require.NotEqual(t, "0", currentUser.Uid,
"this test requires running as normal user, not %s (%s)", currentUser.Username, currentUser.Uid)
require.NotEqual(t, "root", currentUser.Username,
"this test requires running as normal user, not %s (%s)", currentUser.Username, currentUser.Uid)
parentPath := filepath.Join(mf.tempdir, "deep") parentPath := filepath.Join(mf.tempdir, "deep")
testPath := filepath.Join(parentPath, "nesting") testPath := filepath.Join(parentPath, "nesting")
if err := os.Mkdir(parentPath, fs.ModePerm); !assert.NoError(t, err) { if err := os.Mkdir(parentPath, fs.ModePerm); !assert.NoError(t, err) {
@ -209,7 +214,7 @@ func TestCheckSharedStoragePath(t *testing.T) {
assert.Equal(t, testPath, result.Path) assert.Equal(t, testPath, result.Path)
assert.False(t, result.IsUsable) assert.False(t, result.IsUsable)
assert.Contains(t, result.Cause, "Unable to create a file") assert.Contains(t, result.Cause, "Unable to create a file")
}
Sybren A. Stüvel commented 2023-07-07 14:58:52 +02:00
Review
Copy Link

Please keep unrelated formatting changes out of a PR. I'll remove this before landing; this is just a request for other/future PRs.

Please keep unrelated formatting changes out of a PR. I'll remove this before landing; this is just a request for other/future PRs.
} }
} }