studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Web Interface for Tags #104244

Merged
Sybren A. Stüvel merged 30 commits from Evelinealy/flamenco:tag-interface into main 2023-09-04 13:06:10 +02:00
Conversation 6 Commits 30 Files Changed 3 +14 -2
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0be3797283 - Show all commits

16
web/app/src/views/TagsView.vue
View File

@ -38,11 +38,21 @@
> >
<td>{{ tag.name }}</td> <td>{{ tag.name }}</td>
<td>{{ tag.description }}</td> <td>{{ tag.description }}</td>
<!-- Name editing field -->
<td>
<input
type="text"
v-if="isSelected(tag)"
v-model="tag.name"
@blur="updateTagName(tag)"
/>
<span v-else>{{ tag.name }}</span>
</td>
</tr> </tr>
</tbody> </tbody>
</table> </table>
Sybren A. Stüvel commented 2023-08-21 09:30:39 +02:00
Outdated
Review
Copy Link

activeRowIndex is only set, but never read. That means it can be removed.

`activeRowIndex` is only set, but never read. That means it can be removed.
<!-- Show message when no tags found -->
<div v-else class="dl-no-data"> <div v-else class="dl-no-data">
<span>No tags found.</span> <span>No tags found.</span>
</div> </div>
@ -173,7 +183,9 @@ export default {
return; return;
} }
// Find the index of the selected tag in the tags array // Find the index of the selected tag in the tags array
const index = this.tags.findIndex((tag) => tag.id === this.selectedTag.id); const index = this.tags.findIndex(
(tag) => tag.id === this.selectedTag.id
);
if (index !== -1) { if (index !== -1) {
const api = new WorkerMgtApi(getAPIClient()); const api = new WorkerMgtApi(getAPIClient());