studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Web Interface for Tags #104244

Merged
Sybren A. Stüvel merged 30 commits from Evelinealy/flamenco:tag-interface into main 2023-09-04 13:06:10 +02:00
Conversation 6 Commits 30 Files Changed 3 +24 -12
1 changed files with 24 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 30353a76ec - Show all commits

24
web/app/src/views/TagsView.vue
View File

@ -9,15 +9,18 @@
</div> </div>
</div> </div>
<div class="action-buttons"> <div class="action-buttons btn-bar">
<form @submit="createTag"> <form @submit="createTag">
<div class="create-tag-container">
<input <input
type="text" type="text"
name="newtagname" name="newtagname"
v-model="newTagName" v-model="newTagName"
placeholder="New Tag Name" placeholder="New Tag Name"
class="create-tag-input"
/> />
<button type="submit">Create Tag</button> <button id="submit-button" type="submit">Create Tag</button>
</div>
</form> </form>
</div> </div>
@ -26,7 +29,18 @@
<footer class="app-footer"></footer> <footer class="app-footer"></footer>
</template> </template>
Sybren A. Stüvel commented 2023-08-21 09:33:05 +02:00
Outdated
Review
Copy Link

There shouldn't be any need to import this CSS file here. Which problem is this solving?

There shouldn't be any need to import this CSS file here. Which problem is this solving?
<style scoped></style> <style scoped>
.create-tag-container {
width: 100%;
display: flex;
align-items: center;
justify-content: space-between;
}
.create-tag-input {
flex: 1;
margin-right: 10px;
}
</style>
<script> <script>
import { TabulatorFull as Tabulator } from "tabulator-tables"; import { TabulatorFull as Tabulator } from "tabulator-tables";
@ -56,11 +70,9 @@ export default {
mounted() { mounted() {
this.fetchTags(); this.fetchTags();
const vueComponent = this;
const tag_options = { const tag_options = {
columns: [ columns: [
{ title: "Name", field: "name", sorter: "string" }, { title: "Name", field: "name", sorter: "string", editor: "input" },
Sybren A. Stüvel commented 2023-08-21 09:22:55 +02:00
Outdated
Review
Copy Link

I think this is a copy-paste leftover of the jobs table; tags are immediately deleted, whereas jobs are first marked as 'deletion requested' and then deleted by a background process. This line can be removed.

I think this is a copy-paste leftover of the jobs table; tags are immediately deleted, whereas jobs are first marked as 'deletion requested' and then deleted by a background process. This line can be removed.
{ title: "Description", field: "description", sorter: "string" }, { title: "Description", field: "description", sorter: "string" },
], ],
layout: "fitData", layout: "fitData",