studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 63 Pull Requests 5 Releases Wiki Activity

Fix: Tag Interface Delete Button #104256

Manually merged
Sybren A. Stüvel merged 39 commits from Evelinealy/flamenco:tag-interface into main 2023-11-02 16:13:14 +01:00
Conversation 3 Commits 39 Files Changed 1 +5 -7
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 956ec43e99 - Show all commits

12
web/app/src/views/TagsView.vue
View File

@ -164,7 +164,6 @@ export default {
sorter: "string", sorter: "string",
editor: "input", editor: "input",
vertAlign: "center", vertAlign: "center",
width: 400,
dr.sybren marked this conversation as resolved Outdated
Sybren A. Stüvel commented 2023-09-04 23:35:31 +02:00
Outdated
Review
Copy Link

Not sure if a fixed width is going to work well here, especially when the window gets resized.

Not sure if a fixed width is going to work well here, especially when the window gets resized.
formatter(cell) { formatter(cell) {
const cellValue = cell.getData().description; const cellValue = cell.getData().description;
@ -245,16 +244,15 @@ export default {
}, },
deleteTag(tag) { deleteTag(tag) {
if (!tag) {
return;
}
const api = new WorkerMgtApi(getAPIClient()); const api = new WorkerMgtApi(getAPIClient());
api api
dr.sybren marked this conversation as resolved Outdated
Sybren A. Stüvel commented 2023-09-04 23:33:12 +02:00
Outdated
Review
Copy Link

This shouldn't happen anyway, so you can just remove the entire conditional return here. Better to raise an error that you can see & debug (because of the tag.id access failing) than to silently ignore mistakes.

This shouldn't happen anyway, so you can just remove the entire conditional return here. Better to raise an error that you can see & debug (because of the `tag.id` access failing) than to silently ignore mistakes.
.deleteWorkerTag(tag.id) .deleteWorkerTag(tag.id)
.then(() => { .then(() => {
this.tags = this.tags.filter((t) => t.id !== tag.id); this.tabulator.getRows().forEach((row) => {
this.tabulator.setData(this.tags); if (row.getData().id === tag.id) {
row.delete();
}
});
}) })
dr.sybren marked this conversation as resolved Outdated
Sybren A. Stüvel commented 2023-09-04 23:32:39 +02:00
Outdated
Review
Copy Link

This can be removed. The SocketIO handling will already remove the tag, no matter who did the deletion.

This can be removed. The SocketIO handling will already remove the tag, no matter who did the deletion.
.catch((error) => { .catch((error) => {
const errorMsg = JSON.stringify(error); const errorMsg = JSON.stringify(error);