internal/manager/persistence/workers.go

@@ -88,6 +88,15 @@ func (db *DB) FetchWorker(ctx context.Context, uuid string) (*Worker, error) {
 }
 
 func (db *DB) DeleteWorker(ctx context.Context, uuid string) error {
+	// As a safety measure, refuse to delete unless foreign key constraints are active.
+	fkEnabled, err := db.areForeignKeysEnabled()
+	if err != nil {
+		return fmt.Errorf("checking whether foreign keys are enabled: %w", err)
+	}
+	if !fkEnabled {
+		return ErrDeletingWithoutFK
+	}
+
 	tx := db.gormDB.WithContext(ctx).
 		Where("uuid = ?", uuid).
 		Delete(&Worker{})

internal/manager/persistence/workers_test.go

@@ -314,6 +314,30 @@ func TestDeleteWorker(t *testing.T) {
 	}
 }
 
+func TestDeleteWorkerNoForeignKeys(t *testing.T) {
+	ctx, cancel, db := persistenceTestFixtures(t, 1*time.Second)
+	defer cancel()
+
+	// Create a Worker to delete.
+	w1 := Worker{
+		UUID:   "fd97a35b-a5bd-44b4-ac2b-64c193ca877d",
+		Name:   "Worker 1",
+		Status: api.WorkerStatusAwake,
+	}
+	require.NoError(t, db.CreateWorker(ctx, &w1))
+
+	// Try deleting with foreign key constraints disabled.
+	require.NoError(t, db.pragmaForeignKeys(false))
+	require.ErrorIs(t, ErrDeletingWithoutFK, db.DeleteWorker(ctx, w1.UUID))
+
+	// The worker should still exist.
+	{
+		fetchedWorker, err := db.FetchWorker(ctx, w1.UUID)
+		require.NoError(t, err)
+		assert.Equal(t, w1.UUID, fetchedWorker.UUID)
+	}
+}
+
 func TestDeleteWorkerWithTagAssigned(t *testing.T) {
 	f := workerTestFixtures(t, 1*time.Second)
 	defer f.done()