studio/flamenco
studio/flamenco
12
30
Fork 38
Code Issues 64 Pull Requests 5 Releases Wiki Activity

Support pausing jobs #104313

Manually merged
Sybren A. Stüvel merged 28 commits from David-Zhang-10/flamenco:paused-job-status into main 2024-07-01 17:53:44 +02:00
Conversation 1 Commits 28 Files Changed 12 +4 -3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a84097e59f - Show all commits

7
internal/manager/task_state_machine/task_state_machine.go
View File

@ -5,6 +5,7 @@ package task_state_machine
import (
"context"
"fmt"
"projects.blender.org/studio/flamenco/pkg/website"
David-Zhang-10 marked this conversation as resolved Outdated
Sybren A. Stüvel commented 2024-06-17 15:42:40 +02:00
Outdated
Review
Copy Link

Keep the newline between built-in packages and 3rd party packages.

Keep the newline between built-in packages and 3rd party packages.
"github.com/rs/zerolog"
"github.com/rs/zerolog/log"
@ -471,9 +472,9 @@ func (sm *StateMachine) pauseTasks(
return api.JobStatusPaused, nil
}
// This could mean pause was triggered by failure of the job, in which case the
// job is already in the correct status.
return "", nil
// This could mean state transition entered a non-recoverable error state.
log.Warn().Str("jobStatus", string(job.Status)).Msgf("unexpected job status in StateMachine::pauseTasks(), please report this at %s", website.BugReportURL)
return "", fmt.Errorf("unexpected job status %q in StateMachine::pauseTasks()", job.Status)
}
// requeueTasks re-queues all tasks of the job.