Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang commented on pull request blender/blender#119869 2024-08-05 11:54:28 +02:00
Render: allow to select an entire collection to set the focal point in the Depth of Field settings in the Camera properties

@dema can you re-upload your test scene? I believe you deleted it, now the link is not available anymore.

Weizhen Huang commented on pull request blender/blender#119869 2024-08-05 11:50:39 +02:00
Render: allow to select an entire collection to set the focal point in the Depth of Field settings in the Camera properties

BLENDER_RENDER has been removed, this should be CYCLES. (I believe we should clean this up at some point)

Weizhen Huang pushed to main at blender/blender 2024-08-05 10:56:14 +02:00
e981389bdd Refactor: Cycles: use reservoir sampling to pick phase function in volume
7e40d567d4 Fix #125595: Cycles artifacts in overlapping volumes with different phase functions
Compare 2 commits »
Weizhen Huang deleted branch fix-overlapping-volume-with-different-phases from weizhen/blender 2024-08-05 10:56:13 +02:00
Weizhen Huang closed issue blender/blender#125595 2024-08-05 10:56:12 +02:00
Cycles Not handling phase functions of overlapping volumes properly
Weizhen Huang merged pull request blender/blender#125676 2024-08-05 10:56:09 +02:00
Fix #125595: Cycles artifacts in overlapping volumes with different phase functions
Weizhen Huang pushed to main at weizhen/.profile 2024-08-05 10:49:36 +02:00
ad2a549c22 Update reports/2024.md
Weizhen Huang commented on issue blender/blender#125093 2024-08-03 12:34:11 +02:00
oneAPI Embree GPU, transparent shadows will render opaque if transparent bounces is 1024

This is an overflow caused by

#if INTEGRATOR_SHADOW_ISECT_SIZE < 256
using numhit_t = uint8_t;
Weizhen Huang commented on pull request blender/blender#125739 2024-08-03 12:33:15 +02:00
Fix: Cycles BVH2 and Embree missing some transparent shadow bounces

I made a mistake in the previous Embree comment, now the artefacts in #125093 should be gone. The reported problem of opaque hit would be addressed separately.

Weizhen Huang pushed to fix-bvh2-n-closest-hits at weizhen/blender 2024-08-03 12:14:43 +02:00
9726b9e1ea Fix Embree max_t not properly assigned the first time
Weizhen Huang commented on issue blender/blender#125093 2024-08-03 11:33:27 +02:00
oneAPI Embree GPU, transparent shadows will render opaque if transparent bounces is 1024

I can reproduce the issue on Embree with INTEGRATOR_SHADOW_ISECT_SIZE_CPU manually set to 4. I can have a look.

Weizhen Huang commented on pull request blender/blender#125739 2024-08-03 11:05:57 +02:00
Fix: Cycles BVH2 and Embree missing some transparent shadow bounces

@Alaska does it fix #125093 then? Although I do not understand why a value above 1024 would make a difference, 1024 is the threshold for CPU (INTEGRATOR_SHADOW_ISECT_SIZE_CPU).

Weizhen Huang commented on pull request blender/blender#125739 2024-08-03 11:05:06 +02:00
Fix: Cycles BVH2 and Embree missing some transparent shadow bounces

MetalRT, OptiX and HIPRT do not keep track of max_t, but loop through the array to find max_t for all intersections beyond INTEGRATOR_SHADOW_ISECT_SIZE. This is more costly than Embree and…

Weizhen Huang commented on pull request blender/blender#125676 2024-08-02 19:45:48 +02:00
Fix #125595: Cycles artifacts in overlapping volumes with different phase functions

The original code is doing the stuff as the code block you pasted, my first commit didn't change that, if you think that's fine I'll push that first.

Although I didn't measure the performance,…

Weizhen Huang pushed to fix-bvh2-n-closest-hits at weizhen/blender 2024-08-02 19:05:06 +02:00
32b4ffee9f Fix EMBREE as well
Weizhen Huang pushed to main at blender/blender 2024-08-02 16:29:15 +02:00
5b61a01c19 Fix #125750: NaN on Glossy materials with low roughness
Weizhen Huang closed issue blender/blender#125750 2024-08-02 16:29:09 +02:00
Cycles: NaN pixels in Glossy and Transmissive Passes with roughness values near 0.0266
Weizhen Huang merged pull request blender/blender#125756 2024-08-02 16:29:06 +02:00
Fix #125750: NaN on Glossy materials with low roughness