Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-04-18 16:16:11 +02:00
cab3b5eeed Remove unused variable
Weizhen Huang commented on pull request blender/blender#105600 2023-04-18 16:05:06 +02:00
Cycles: new Microfacet-based Hair BSDF with elliptical cross-section support

Not sure why this was 4 before, there are only 2 closures, ...HairBSDF and ...HairExtra.

Weizhen Huang commented on pull request blender/blender#105600 2023-04-18 16:05:05 +02:00
Cycles: new Microfacet-based Hair BSDF with elliptical cross-section support

These are utitily functions for matching direct color with absorption coefficient. They are designed for Principled Hair BSDF, and don't seem to match very well with the Microfacet Hair BSDF. Currently I just "borrow" these functions so direct coloring is also available for the new model. I could move the three shared functions to bsdf_util.h, or duplicate them in bsdf_hair_microfacet.h, if this matters.

Weizhen Huang commented on pull request blender/blender#105600 2023-04-18 16:05:05 +02:00
Cycles: new Microfacet-based Hair BSDF with elliptical cross-section support

The curve normal (which is needed for orienting the cross-section) is not considered in the legacy hair curve. I don't want to put too much effort into this if the legacy curve is to be discarded at some point.

Weizhen Huang pushed to main at blender/blender 2023-04-18 11:58:18 +02:00
4d7a7ce67c Fix #107050: accessing nullptr after progress is canceled
Weizhen Huang closed issue blender/blender#107050 2023-04-18 11:58:17 +02:00
Regression: Dragging Colorramp in shader with emission crashes (Cycles LightTree)
Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-04-17 19:33:01 +02:00
1b08175c30 Add back SD_BSDF_HAS_TRANSMISSION flag
Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-04-17 11:13:34 +02:00
778de47f31 Merge remote-tracking branch 'origin' into microfacet_hair
1c6d728248 Negate tilt in setup() instead of eval() and sample()
a8c3ba0593 Precalculate some quantities
5491563e59 Fix #106982: crash with muted node
6e59d0b20f Cleanup: document type of Scene::view_layers
Compare 98 commits »
Weizhen Huang commented on issue blender/blender#106876 2023-04-14 20:29:31 +02:00
Regression: LightTree failing with large number of emitters

@iss the pull request is merged as bfd1836861, can you check if we can close the issue now?

Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-04-14 19:46:48 +02:00
c499e2247b small cleanups
Weizhen Huang deleted branch light_tree_instance from weizhen/blender 2023-04-14 19:21:57 +02:00
Weizhen Huang closed pull request blender/blender#106683 2023-04-14 19:14:34 +02:00
Cycles: add instancing support in light tree
Weizhen Huang commented on pull request blender/blender#106683 2023-04-14 19:14:32 +02:00
Cycles: add instancing support in light tree

committed as bfd1836861

Weizhen Huang pushed to main at blender/blender 2023-04-14 19:13:03 +02:00
bfd1836861 Cycles: add instancing support in light tree
Weizhen Huang pushed to light_tree_instance at weizhen/blender 2023-04-14 18:48:57 +02:00
49ede3338d Merge branch 'main' into light_tree_instance
d633d9fd02 Curves: Define "lookup int" function for RNA arrays
dcb3b1c1f9 Geometry: Use implicit sharing for curve and mesh offsets
fed463df78 IDManagement: Extend ID remapping code.
Compare 4 commits »
Weizhen Huang commented on pull request blender/blender#106683 2023-04-14 17:51:39 +02:00
Cycles: add instancing support in light tree

Thanks for the patch. The two proposed alternatives require the same amount of memory (16 bytes more compared to the version with union), but with variant the intention of the code is clearer…

Weizhen Huang commented on pull request blender/blender#106683 2023-04-14 17:02:04 +02:00
Cycles: add instancing support in light tree

@blender-bot package

Weizhen Huang pushed to light_tree_instance at weizhen/blender 2023-04-14 17:00:45 +02:00
c10023b8e3 Add #include <variant>
Weizhen Huang commented on pull request blender/blender#106683 2023-04-14 16:49:55 +02:00
Cycles: add instancing support in light tree

@blender-bot package

Weizhen Huang pushed to light_tree_instance at weizhen/blender 2023-04-14 16:48:05 +02:00
a8e5aa4bcc Merge remote-tracking branch 'origin' into light_tree_instance
490f41856b Change light tree node type from union to variant
988f23cec3 Attributes: Add 2D integer vector attribute type
80f3f59555 Fix: Remove unsupported data types in extrude and split edges nodes
3f31ac2e1a Cleanup: Make deprecated custom data type handling consistent
Compare 41 commits »