Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-03-09 15:45:35 +01:00
6858fba43d Add identifier to a few input sockets
Weizhen Huang created pull request blender/blender#105600 2023-03-09 15:02:32 +01:00
WIP: Cycles: new Microfacet-base Hair BSDF with elliptical cross-section support
Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-03-09 14:55:13 +01:00
d0cb0d5fbc Merge remote-tracking branch 'origin' into microfacet_hair
85a70e9756 Fix memory leak with button tooltip callback and decorator buttons
3b900048f1 Animation: Move Graph Editor settings to User Preferences
0239eee1c6 Fix build error on Windows introduced in 46be42f6b1
7edb3ab5e0 Merge branch 'blender-v3.5-release'
Compare 1234 commits »
Weizhen Huang commented on pull request blender/blender#105596 2023-03-09 14:31:28 +01:00
Fix #105553: do not copy "Roughness" value from the previous node

Jacques was suggesting comparing the identifier instead of name. identifier is default to name if not specified: https://projects.blender.org/blender/blender/src/commit/3b900048f1c5ec098ade

Weizhen Huang created pull request blender/blender#105596 2023-03-09 11:59:37 +01:00
Fix #105553: do not copy "Roughness" value from the previous node
Weizhen Huang deleted branch do_not_copy_roughness_and_transmission from weizhen/blender 2023-03-09 11:58:00 +01:00
Weizhen Huang created branch do_not_copy_roughness in weizhen/blender 2023-03-09 11:57:14 +01:00
Weizhen Huang pushed to do_not_copy_roughness at weizhen/blender 2023-03-09 11:57:14 +01:00
Weizhen Huang pushed to do_not_copy_roughness_and_transmission at weizhen/blender 2023-03-09 11:55:06 +01:00
5336a00353 Fix #105553: do not copy "Roughness" value from the previous node
Weizhen Huang pushed to do_not_copy_roughness_and_transmission at weizhen/blender 2023-03-09 11:50:50 +01:00
9b25f5c73d Fix #105553: do not copy "Roughness" and "Transmission" values from the previous node
560314b7fd Merge branch 'blender-v3.5-release'
a4fd2d10c1 Fix #105571: crash when connecting invalid node group to multi input
c20bf8d61e GPU: Replace old shader tests with shader builder.
0ad06cd39d Vulkan: Automap Buffers.
Compare 10 commits »
Weizhen Huang created branch do_not_copy_roughness_and_transmission in weizhen/blender 2023-03-09 11:50:50 +01:00
Weizhen Huang commented on pull request blender/blender#104888 2023-03-09 11:17:09 +01:00
Gizmo: add undo and name

The purpose of this patch was to get undo with RNA information in a quick and dirty way, I looked into the proper way with RNA only after that, so these commits have a dependency, and I won't…

Weizhen Huang pushed to main at blender/blender 2023-03-08 15:06:08 +01:00
b9649c2e72 Eevee: fall back to Diffuse BSDF before proper implementation of Hair BSDFs
Weizhen Huang commented on issue blender/blender#105553 2023-03-08 10:45:35 +01:00
When changing the node type in material, sockets of different node types are reused

Ok I see your point now, this is assuming that different nodes with the same input name have the same meaning, so the value can be copied from the previous one. This makes sense sometimes, maybe…

Weizhen Huang commented on issue blender/blender#105553 2023-03-08 10:10:32 +01:00
When changing the node type in material, sockets of different node types are reused

I don't think different default values is a bug, it's reasonable for different shaders to have different default values, they shouldn't interfere with each other.

Weizhen Huang commented on issue blender/blender#105553 2023-03-08 10:04:53 +01:00
When changing the node type in material, sockets of different node types are reused

That is only the default "Roughness" value for Principled BSDF. Glossy BSDF also has a "Roughness" of 0.5 https://projects.blender.org/blender/blender/src/commit/b1185da40341bf1fb6deda37449857facc4

Weizhen Huang commented on issue blender/blender#105553 2023-03-08 01:07:02 +01:00
When changing the node type in material, sockets of different node types are reused

This issue is not limited to the name "Roughness". For example Principled BSDF has a field called "Transmission" with a default value of 0. If I write another shader with a "Transmission" field…

Weizhen Huang opened issue blender/blender#105553 2023-03-08 00:59:02 +01:00
Wrong default value in shaders
Weizhen Huang pushed to main at blender/blender 2023-03-07 17:08:47 +01:00
5ff959a056 Fix BLI_assert 'attr->comp_len == 2' failed in cage 2d gizmo
Weizhen Huang pushed to main at blender/blender 2023-03-07 16:29:40 +01:00
48944e7a8e Gizmo: slightly increase cage2d corner margins
275d69467b Gizmo: show hovering regions of cage2d gizmo to indicate constraint axis
Compare 2 commits »