Weizhen Huang weizhen
19 Followers · 0 Following
  • Joined on 2022-10-03
Repositories
2
 Projects Public Activity Starred Repositories
Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-02-27 18:35:29 +01:00
733b30c6a3 Add option to show light color
Weizhen Huang created pull request blender/blender#105236 2023-02-27 11:27:22 +01:00
WIP: draw light icon using the light color
Weizhen Huang created branch colorful_light_icon in weizhen/blender 2023-02-27 11:15:00 +01:00
Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-02-27 11:15:00 +01:00
f52a233129 WIP: draw light icon using the light color
16aab1508d Cleanup: comment out unused parameters from last commit
08af0f1204 Fix setting the active vertex color when assigning false
30db096cc8 Cleanup: quiet compiler warnings
dc08ff3c2e Cleanup: spelling in comments
Compare 10 commits »
Weizhen Huang pushed to main at blender/blender 2023-02-24 23:10:46 +01:00
6166dac3ee Gizmo: support scaling of light gizmos with zero size
Weizhen Huang pushed to enable_gizmo_undo at weizhen/blender 2023-02-24 14:46:02 +01:00
db95b7226c Refactor: Gizmo: transform RNA properties in light gizmos
aa9edfb462 Refactor: Gizmo: update area light size via RNA instead of setting manually
95fbfba052 Gizmo: display gizmo name in tooltip
103419691a Gizmo: enable undo for light gizmos
6b89ce3c64 Cleanup: use available #wmGizmoPropertyFnParams
Compare 146 commits »
Weizhen Huang commented on pull request blender/blender#105022 2023-02-21 16:18:29 +01:00
Fix Light Tree option causing wrong renders on macOS AMD

Typo in the comment :DD

Weizhen Huang approved blender/blender#105022 2023-02-21 16:13:24 +01:00
Fix Light Tree option causing wrong renders on macOS AMD
Weizhen Huang commented on pull request blender/blender#105022 2023-02-21 15:49:36 +01:00
Fix Light Tree option causing wrong renders on macOS AMD

But according to scene.cpp the light manager is updated before the integrator? If light manager is updated after the integrator I agree it would be better to remove the other one. But yes if…

Weizhen Huang commented on pull request blender/blender#105022 2023-02-21 15:16:03 +01:00
Fix Light Tree option causing wrong renders on macOS AMD

I think this line can be deleted.

Weizhen Huang commented on pull request blender/blender#104888 2023-02-21 15:15:38 +01:00
Gizmo: add undo and name

I find it a bit confusing that there are two groups of getter/setters. The new transform_set_fn could modify the value, and I don't want to drop the const specifier for value_set_fn. Or could there be better function names?

Weizhen Huang commented on pull request blender/blender#104888 2023-02-21 15:15:38 +01:00
Gizmo: add undo and name

Usually description is used here, but looks rather lengthy if there is already description for RNA properties, so I use name instead.

Weizhen Huang commented on pull request blender/blender#104888 2023-02-21 15:15:38 +01:00
Gizmo: add undo and name

I find this get_unique concept quite strange, it is here because gizmos are allowed to have multiple properties, and if there are multiple I don't know which one just got edited, and could it be that only one of them has undo.

Weizhen Huang pushed to enable_gizmo_undo at weizhen/blender 2023-02-20 17:24:40 +01:00
2de990a55c Refactor: Gizmo: transform RNA properties in light gizmos
53a0946b2e Refactor: Gizmo: update area light size via RNA instead of setting manually
55826ea5a6 Gizmo: display gizmo name in tooltip
4a7fc3d5b2 Gizmo: enable undo for light gizmos
b2e6a6c987 Cleanup: use available #wmGizmoPropertyFnParams
Compare 56 commits »
Weizhen Huang commented on issue blender/blender#104280 2023-02-20 13:21:19 +01:00
Improve visualisation and manipulation of lights in the viewport

@slwk1d thank you for your feedback.

  • Point light theoretically should have a radius of 0, so I don't see a problem of a default value of 0. But it seems a bug that the move gizmo is drawn over…
Weizhen Huang pushed to main at blender/blender 2023-02-17 19:17:10 +01:00
d6774174e9 Fix compile error due to previous changes
Weizhen Huang opened issue infrastructure/blender-projects-platform#42 2023-02-17 16:29:30 +01:00
Same command line instructions for "Rebase then fast-forward" and "Create squash commit"
Weizhen Huang created pull request blender/blender#104888 2023-02-17 16:21:41 +01:00
Gizmo: add undo and name
Weizhen Huang created branch enable_gizmo_undo in weizhen/blender 2023-02-17 16:18:00 +01:00
Weizhen Huang pushed to enable_gizmo_undo at weizhen/blender 2023-02-17 16:18:00 +01:00
c1ae1ac248 Gizmo: display gizmo name in tooltip
4816f7c02c Gizmo: enable undo for light gizmos
ca2d347b4c Cleanup: use available #wmGizmoPropertyFnParams
08f24553dc Cleanup: Remove accidentally merged TODO comment
7838eb12c6 Merge branch 'blender-v3.5-release'
Compare 10 commits »