Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang commented on pull request blender/blender#105862 2023-03-20 12:30:19 +01:00
Cycles: build Light Tree in parallel

Build again with MIN_PRIMS_PER_THREAD set to INT_MAX to test the parallel build.

@blender-bot build

Weizhen Huang pushed to parallel_light_tree at weizhen/blender 2023-03-20 12:28:57 +01:00
1b9d56ce9c Cycles: build Light Tree in parallel
Weizhen Huang commented on pull request blender/blender#105862 2023-03-20 11:51:56 +01:00
Cycles: build Light Tree in parallel
Weizhen Huang pushed to parallel_light_tree at weizhen/blender 2023-03-20 11:42:37 +01:00
66b46eee66 Cycles: build Light Tree in parallel
Weizhen Huang pushed to parallel_light_tree at weizhen/blender 2023-03-20 11:39:42 +01:00
8bd9a5bf0a Cycles: build Light Tree in parallel
5584c1cb53 IO: add PLY export test coverage for loose edges and loose vertices
4c70d9e11a Merge branch 'blender-v3.5-release'
de49d18af5 Fix: Invalid custom data read during legacy mesh format conversion
7cda559d7c Cleanup: format, spelling, struct member comment
Compare 38 commits »
Weizhen Huang created pull request blender/blender#105862 2023-03-17 20:08:39 +01:00
WIP: Cycles: build Light Tree in parallel
Weizhen Huang pushed to parallel_light_tree at weizhen/blender 2023-03-17 20:04:20 +01:00
26d66945c6 Cycles: build Light Tree in parallel
728694b4e4 Cleanup: use array instead of vector for LightTreeBucket with fixed size
a1a11b08d8 Cleanup: added a bunch of const qualifiers in Light Tree
74070a1c2c Merge branch 'blender-v3.5-release'
ddec556ef3 Fix make_update running on a freshly cloned Blender fork
Compare 10 commits »
Weizhen Huang created branch parallel_light_tree in weizhen/blender 2023-03-17 20:04:20 +01:00
Weizhen Huang pushed to main at blender/blender 2023-03-17 20:01:44 +01:00
728694b4e4 Cleanup: use array instead of vector for LightTreeBucket with fixed size
a1a11b08d8 Cleanup: added a bunch of const qualifiers in Light Tree
Compare 2 commits »
Weizhen Huang pushed to main at blender/blender 2023-03-17 15:28:47 +01:00
d9273d8578 Fix Cycles growing BoundBox with empty BoundBox modifies the original BoundBox
Weizhen Huang pushed to no_normal_trick_for_diffuse at weizhen/blender 2023-03-16 11:29:39 +01:00
4a1377c056 Cleanup: remove unused function for osl
Weizhen Huang commented on pull request blender/blender#105776 2023-03-15 20:44:29 +01:00
Cycles: only apply function #ensure_valid_reflection to glossy materials

Commited changes, the behavior should be the same before, except for CLOSURE_BSDF_GLOSSY_TOON_ID, as I don't really know what ATTR_FALLTHROUGH is doing.

Weizhen Huang pushed to no_normal_trick_for_diffuse at weizhen/blender 2023-03-15 20:38:34 +01:00
b71ab424c4 Refactor: call #ensure_valid_specular_reflection in separate cases
Weizhen Huang commented on pull request blender/blender#105776 2023-03-15 19:45:35 +01:00
Cycles: only apply function #ensure_valid_reflection to glossy materials

It should be taken care by the early out case, but if N == Ng the function should do nothing so maybe we could have an even-earlier-out case? I thought this function is not called when N == Ng, but maybe my memory is broken

Weizhen Huang commented on pull request blender/blender#105776 2023-03-15 19:45:35 +01:00
Cycles: only apply function #ensure_valid_reflection to glossy materials

I totally forgot to add you, how did you find out my pull request 😮

Weizhen Huang pushed to no_normal_trick_for_diffuse at weizhen/blender 2023-03-15 19:39:24 +01:00
917aaf5929 Cleanup: format EEVEE
Weizhen Huang commented on pull request blender/blender#105776 2023-03-15 19:10:28 +01:00
Cycles: only apply function #ensure_valid_reflection to glossy materials

Both CLOSURE_IS_BSDF_GLOSSY(CLOSURE_BSDF_PRINCIPLED_ID) and CLOSURE_IS_BSDF_TRANSMISSION(CLOSURE_BSDF_PRINCIPLED_ID) is false, so the function would only be called once in the case below.

Weizhen Huang pushed to no_normal_trick_for_diffuse at weizhen/blender 2023-03-15 17:27:48 +01:00
5d2129f208 Cleanup: rename function
35b612619a Cycles: only apply function #ensure_valid_reflection to glossy materials
Compare 2 commits »
Weizhen Huang pushed to no_normal_trick_for_diffuse at weizhen/blender 2023-03-15 17:17:05 +01:00
6a7c6f7cae Cycles: only apply function #ensure_valid_reflection to glossy materials
b75a59a2ab Refactor: simplify computations in function #ensure_valid_reflection
19ca2e905e UI: Increase the size of the "Open Recent" list
c0e757a713 UI: Add scroll to sidebar tabs
81818b797b Merge branch 'blender-v3.5-release'
Compare 17 commits »
Weizhen Huang commented on pull request blender/blender#105776 2023-03-15 17:03:35 +01:00
Cycles: only apply function #ensure_valid_reflection to glossy materials

There are discussions regarding whether ensure_valid_reflection() should be called for transmissive materials or only purely reflective glossy materials. The current microfacet implementation…