Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang commented on issue blender/blender#105553 2023-03-08 01:07:02 +01:00
When changing the node type in material, sockets of different node types are reused

This issue is not limited to the name "Roughness". For example Principled BSDF has a field called "Transmission" with a default value of 0. If I write another shader with a "Transmission" field…

Weizhen Huang opened issue blender/blender#105553 2023-03-08 00:59:02 +01:00
Wrong default value in shaders
Weizhen Huang pushed to main at blender/blender 2023-03-07 17:08:47 +01:00
5ff959a056 Fix BLI_assert 'attr->comp_len == 2' failed in cage 2d gizmo
Weizhen Huang pushed to main at blender/blender 2023-03-07 16:29:40 +01:00
48944e7a8e Gizmo: slightly increase cage2d corner margins
275d69467b Gizmo: show hovering regions of cage2d gizmo to indicate constraint axis
Compare 2 commits »
Weizhen Huang pushed to show_gizmo_constraint at weizhen/blender 2023-03-07 15:31:04 +01:00
792850441b Gizmo: draw thick lines on cage2d edges when hovering to indicate constraint axis
6fbc52bdca Viewport: draw light icons using the light colors
891eb4938c UI: add parenting (Keep Transform Without Inverse) to menu
4aea5df231 Cleanup: Use CPP Wrapper to Clear SSBO in Eevee-next.
7f5d1fb05a Merge branch 'blender-v3.5-release' into main
Compare 682 commits »
Weizhen Huang deleted branch colorful_light_icon from weizhen/blender 2023-03-07 15:19:58 +01:00
Weizhen Huang closed pull request blender/blender#105236 2023-03-07 15:19:45 +01:00
Viewport: draw light icons using the light colors
Weizhen Huang commented on pull request blender/blender#105236 2023-03-07 15:19:44 +01:00
Viewport: draw light icons using the light colors

Committed as 6fbc52bdca3b38872c178dbafe0abc92328927e3

Weizhen Huang pushed to main at blender/blender 2023-03-07 15:18:12 +01:00
6fbc52bdca Viewport: draw light icons using the light colors
Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-03-07 15:06:28 +01:00
aa4201dc7f Only color the outer ring and the sun rays
3246c574ef Cleanup: delete space in CMake file
6ccc1c12b0 Cleanup: remove RNA access when getting light color
4c89bc2406 Add option to show light color
e3d29ab5ce WIP: draw light icon using the light color
Compare 5 commits »
Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-03-07 15:02:13 +01:00
4508c6fc6e Only color the outer ring and the sun rays
c6fafe0034 Cleanup: delete space in CMake file
fd18792f0c Cleanup: remove RNA access when getting light color
d558edb19e Add option to show light color
505145e8e2 WIP: draw light icon using the light color
Compare 199 commits »
Weizhen Huang pushed to microfacet_hair at blender/blender 2023-03-07 15:00:11 +01:00
a903e7bb32 Merge remote-tracking branch 'origin' into microfacet_hair
7f5d1fb05a Merge branch 'blender-v3.5-release' into main
4eb88bca58 Gitea: use full URL for referencing pull requests
a668e3b73a I18n: do not translate a message already translated using iface_()
ae530592fe I18n: disambiguate messages
Compare 32 commits »
Weizhen Huang pushed to microfacet_hair at blender/blender 2023-03-07 14:21:04 +01:00
b7070df8a7 Merge remote-tracking branch 'origin' into microfacet_hair
c26566ad27 Drivers: Introduce the Context Properties
4fb6e45b37 Curves: change default font offset from 1.0 to 0.0
4dc59c7311 I18n: add per-socket translation contexts for nodes
61b457d390 Vulkan: Push constants
Compare 1112 commits »
Weizhen Huang commented on pull request blender/blender#105236 2023-02-28 17:34:02 +01:00
Viewport: draw light icons using the light colors

Not sure about getting into such details, because different light types with the same power could have quite different perceptual strength, it also depends on the size/radius and the spread of the…

Weizhen Huang commented on pull request blender/blender#105236 2023-02-28 17:28:58 +01:00
Viewport: draw light icons using the light colors

The other function DRW_cache_light_icon_sun_rays_get() draw the rays. (I could delete the word "icon" if it's inappropriate). What's left of this DRW_cache_light_sun_lines_get() only draws…

Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-02-28 16:45:01 +01:00
e375b9714b Only color the outer ring and the sun rays
b315a3f795 Cleanup: delete space in CMake file
6f637475d0 Cleanup: remove RNA access when getting light color
ecc43b81ba Add option to show light color
d1a3ddd3ed WIP: draw light icon using the light color
Compare 67 commits »
Weizhen Huang commented on pull request blender/blender#105236 2023-02-28 16:36:09 +01:00
Viewport: draw light icons using the light colors

I am following the comment I deleted for drawing the part, it was /* Light Icon */. Now we draw the inner circles and the outer circle separately, it's weird to call all of them "center". If…

Weizhen Huang commented on pull request blender/blender#105236 2023-02-28 16:28:43 +01:00
Viewport: draw light icons using the light colors

Now this poor function only draws the light direction, not sure if we should rename it. I was considering adding a function that only draws the light direction because it is shared by other light types, but then other light types also draw clip start and end, so they are different.

Weizhen Huang commented on pull request blender/blender#105236 2023-02-28 16:25:34 +01:00
Viewport: draw light icons using the light colors

I am not sure if coloring the light should be default. Currently it is disabled by default.

Weizhen Huang pushed to colorful_light_icon at weizhen/blender 2023-02-28 16:21:46 +01:00
3ddb17c59e Only color the outer ring and the sun rays