Weizhen Huang weizhen
18 Followers · 0 Following
  • Joined on 2022-10-03
Repositories
2
 Projects Public Activity Starred Repositories
Weizhen Huang pushed to fix-metal-atan2 at weizhen/blender 2024-08-30 12:39:14 +02:00
8f435f5b2c Return 0 instead
Weizhen Huang commented on pull request blender/blender-test-data#10 2024-08-30 12:07:04 +02:00
Shader: add test files for Metallic BSDF and Light Tree

@fclem If you think the metallic tests look fine I can push that first? The problem with the light tree test we can investigate later.

Weizhen Huang commented on pull request blender/blender#126951 2024-08-30 12:02:56 +02:00
Fix #126799: undefined behavior of shader node Arctan2 at (0, 0)

@Sergey @fclem The behavior I described in the commit message holds for Cycles but not for EEVEE, what do you think of returning 0 for atan2(0, 0) no matter of the sign?

That means we need to…

Weizhen Huang commented on pull request blender/blender#126951 2024-08-30 11:11:18 +02:00
Fix #126799: undefined behavior of shader node Arctan2 at (0, 0)

2.35547 looks like 3\pi/4, that's weird.

@Alaska can you try this file where I replaced all the links to Light Path with 0, to see if it's a problem with atan2() or something else? I…

Weizhen Huang commented on pull request blender/blender#126951 2024-08-29 22:44:02 +02:00
Fix #126799: undefined behavior of shader node Arctan2 at (0, 0)

I created a test file for the four different cases. It seems that EEVEE has some problem preserving the sign of zeros. In the material atan2(-0, -0) + 4, if I remove the link to Light Path…

Weizhen Huang pushed to fix-metal-atan2 at weizhen/blender 2024-08-29 22:10:44 +02:00
a44df294ff Cleanup: move code block into function
Weizhen Huang created pull request blender/blender#126951 2024-08-29 21:08:58 +02:00
Fix #126799: undefined behavior of atan2 on Metal
Weizhen Huang pushed to fix-metal-atan2 at weizhen/blender 2024-08-29 21:06:32 +02:00
d4b3795c2f Fix #126799: undefined behavior of atan2 on Metal
69add5aa47 Cleanup: PBVH: Standardize some usage of node grid indices
9791625ae3 Cleanup: PBVH: Add accessor for node triangle indices
347ec1acd7 Refactor: Sculpt: Switch to new API for BVH node selection & data access
1c1e389d4b Refactor: misc improvements to the channel groups code
Compare 10 commits »
Weizhen Huang created branch fix-metal-atan2 in weizhen/blender 2024-08-29 21:06:32 +02:00
Weizhen Huang commented on pull request blender/blender-test-data#10 2024-08-28 12:41:43 +02:00
Shader: add test files for Metallic BSDF and Light Tree

@fclem would you like to have a look at the test files and adjust some parameters for EEVEE?

For metallic test the most obvious difference is on the purple ball, where EEVEE is missing…

Weizhen Huang created pull request blender/blender-test-data#10 2024-08-28 12:39:48 +02:00
Shader: add test files for Metallic BSDF and Light Tree
Weizhen Huang commented on pull request blender/blender#126882 2024-08-28 12:39:07 +02:00
Tests: add test files for Metallic BSDF and Light Tree

@blender-bot build

Weizhen Huang created pull request blender/blender#126882 2024-08-28 12:38:49 +02:00
Tests: add test files for Metallic BSDF and Light Tree
Weizhen Huang pushed to metallic-light-tree-tests at weizhen/blender 2024-08-28 12:38:18 +02:00
7ca8ae1caa Tests: add test files for Metallic BSDF and Light Tree
84bab7f300 Fix #126592: Cycles light tree subtended angle not covering the entire bounding box
21b820cd33 Fix the type value of 'bpy.types.*.bl_rna'
25b2c5f170 BLI: Add reduce_mul
17397dae19 Fix #125680: Grease Pencil edit overlay shader theme switch
Compare 10 commits »
Weizhen Huang created branch metallic-light-tree-tests in weizhen/blender 2024-08-28 12:38:18 +02:00
Weizhen Huang pushed to metallic-light-tree at blender/blender-test-data 2024-08-28 12:36:02 +02:00
5cbe4a398f Shader: add test files for Metallic BSDF and Light Tree
Weizhen Huang created branch metallic-light-tree in blender/blender-test-data 2024-08-28 12:36:02 +02:00
Weizhen Huang deleted branch light_tree_bounding_sphere from blender/blender-test-data 2024-08-28 11:54:48 +02:00
Weizhen Huang pushed to main at blender/blender 2024-08-28 11:54:15 +02:00
84bab7f300 Fix #126592: Cycles light tree subtended angle not covering the entire bounding box
Weizhen Huang closed issue blender/blender#126592 2024-08-28 11:54:13 +02:00
Cycles light tree misses some light samples