Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang commented on pull request blender/blender#118477 2024-04-16 16:49:33 +02:00
Cycles: Add thin film iridescence to Principled BSDF

WI think we could default to the IOR of water, which is 1.33.

Weizhen Huang commented on pull request blender/blender#118477 2024-04-16 16:49:32 +02:00
Cycles: Add thin film iridescence to Principled BSDF

Specify the unit (nm).

Weizhen Huang commented on pull request blender/blender#118477 2024-04-16 16:49:31 +02:00
Cycles: Add thin film iridescence to Principled BSDF

Why not sqrtf() here?

Weizhen Huang commented on pull request blender/blender#118477 2024-04-16 16:49:30 +02:00
Cycles: Add thin film iridescence to Principled BSDF

I believe we should trust fresnel_dielectric_polarized() instead of checking TIR before calling the function.

Weizhen Huang commented on pull request blender/blender#118477 2024-04-16 16:49:28 +02:00
Cycles: Add thin film iridescence to Principled BSDF

This function is almost identical as fresnel_dielectric() except for the phase computation, would it be practical to reuse that function? The phase computation could then be:

Weizhen Huang commented on pull request blender/blender#118477 2024-04-16 16:49:28 +02:00
Cycles: Add thin film iridescence to Principled BSDF

What is this TODO?

Weizhen Huang pushed to restir at weizhen/blender 2024-04-16 14:52:05 +02:00
da4c2bdc0f Add spatial resampling
Weizhen Huang pushed to restir at weizhen/blender 2024-04-16 00:08:51 +02:00
7e0ff553da Refactor: make restir an init function
5d56337f80 Cleanup: comments, change function parameters, split reservoir and sd
b1f3649604 Refactor: move 1/pdf to weight instead of a multiplicator of radiance
e49376f06d Remove ReSTIR from megakernel
4c775a220c Fix function parameter difference in declaration and definition
Compare 230 commits »
Weizhen Huang pushed to restir at weizhen/blender 2024-04-15 14:56:33 +02:00
10c002349e Fix point light zero radius ls->t not written
aef5054931 Read reservoir in a second pass
b8c8f63c19 Fix: point light t and P not written
2942e4b8cf Refactor: write to reservoir only when it is direct illumination
2a8c152aae Cleanup: split restir.h and reservoir.h
Compare 8 commits »
Weizhen Huang pushed to cycles-cleanup at weizhen/blender 2024-04-13 12:04:41 +02:00
c0e779b632 Cleanup: deduplicate assignment of background light group
Weizhen Huang pushed to cycles-cleanup at weizhen/blender 2024-04-13 11:31:49 +02:00
b40cfe6c61 Cleanup: deduplicate assignment of background light group
Weizhen Huang pushed to restir at weizhen/blender 2024-04-12 16:48:21 +02:00
2ee468d2ed Also support point light
c500227a4e Refactor: shuffle some code around in Cycles light
Compare 2 commits »
Weizhen Huang pushed to cycles-cleanup at weizhen/blender 2024-04-12 14:02:35 +02:00
5dd117242f Refactor: shuffle some code around in Cycles light
Weizhen Huang pushed to restir at weizhen/blender 2024-04-12 12:07:26 +02:00
1204a8647b Write ShaderData to render buffer and render later
4ad690abe6 Refactor: wrap block of codes into functions
8e3b141756 Cleanup: remove unused parameters
15956e6ddc Cleanup: reduce code duplication in forward MIS weight
3b635cdb95 Recover Area Light Sample from uv
Compare 35 commits »
Weizhen Huang pushed to cycles-cleanup at weizhen/blender 2024-04-11 17:39:13 +02:00
80d6a73f16 Refactor: wrap block of codes into functions
Weizhen Huang pushed to cycles-cleanup at weizhen/blender 2024-04-11 17:21:13 +02:00
b94781204d Cleanup: remove unused parameters
Weizhen Huang pushed to cycles-cleanup at weizhen/blender 2024-04-11 15:12:43 +02:00
870c8a4663 Cleanup: reduce code duplication in forward MIS weight
e862781340 Cleanup: remove unnecessary shader flag in Chiang Hair BSDF
cc0ff8ec06 Cleanup: pass shader flag as parameter instead of ShaderData
23bd7fd552 Cleanup: use available function to compute render buffer pointer
b7f8006bb8 Cleanup: reduce code duplication in surface MIS
Compare 78 commits »
Weizhen Huang pushed to cycles-cleanup at weizhen/blender 2024-04-09 17:53:28 +02:00
d1b89f826c Cleanup: remove unnecessary shader flag in Chiang Hair BSDF
787548e7b3 Cleanup: pass shader flag as parameter instead of ShaderData
f1b7065fbb Cleanup: use available function to compute render buffer pointer
0a1debb13d Cleanup: reduce code duplication in surface MIS
65b38942b0 Cleanup: remove unused function parameters
Compare 5 commits »
Weizhen Huang created branch cycles-cleanup in weizhen/blender 2024-04-09 17:53:28 +02:00