Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang closed issue blender/blender#73184 2024-03-25 15:21:06 +01:00
Cycles Principled shader Fresnel glitches
Weizhen Huang commented on issue blender/blender#73184 2024-03-25 15:21:02 +01:00
Cycles Principled shader Fresnel glitches

Seems to be fixed already. From the attached file I see nothing out of the ordinary, EEVEE and Cycles also match well.

Weizhen Huang commented on issue blender/blender#72553 2024-03-25 15:12:22 +01:00
Cycles, inconsistent power units between mesh light and rectangle area light

The strength unit for mesh light is W/sr/m^2, integrated over the area and the hemisphere a factor of πA is expected, see blender/blender#108505 Can this…

Weizhen Huang commented on pull request blender/blender#119389 2024-03-25 15:07:18 +01:00
Fix #114634: correlated samples in volume when using equiangular sampling and light tree

Effectively we are still reusing the same random number to sample the light position from volume segment and from position, but that doesn't seem to cause problem as I observed. It was using the…

Weizhen Huang commented on pull request blender/blender#119389 2024-03-25 15:00:48 +01:00
Fix #114634: correlated samples in volume when using equiangular sampling and light tree

No. The change is that we determine the light to be sampled already in volume segment, not the light position. A new position would be sampled from the direct scattering position. Before this…

Weizhen Huang pushed to fix-volume-light-tree at weizhen/blender 2024-03-25 13:10:52 +01:00
6c057c034d Merge remote-tracking branch 'origin' into fix-volume-light-tree
082b68fcb9 Cycles: improve equiangular sampling in volume
ab93a426a0 Fix assert from recent cleanup
2e8259e4d4 GPv3: Clean loose points in draw mode menu
7371b11bb5 Fix #119871: Window contents invalid on startup under Wayland & GNOME
Compare 88 commits »
Weizhen Huang deleted branch equiangular-valid-range from weizhen/blender 2024-03-25 13:02:17 +01:00
Weizhen Huang pushed to main at blender/blender 2024-03-25 13:02:14 +01:00
082b68fcb9 Cycles: improve equiangular sampling in volume
Weizhen Huang merged pull request blender/blender#119438 2024-03-25 13:02:14 +01:00
Cycles: improve equiangular sampling in volume
Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-25 13:00:51 +01:00
35eb97037a Add test file
01620ce3fc Merge remote-tracking branch 'origin' into equiangular-valid-range
ab93a426a0 Fix assert from recent cleanup
2e8259e4d4 GPv3: Clean loose points in draw mode menu
7371b11bb5 Fix #119871: Window contents invalid on startup under Wayland & GNOME
Compare 88 commits »
Weizhen Huang pushed to main at blender/blender-test-data 2024-03-25 13:00:35 +01:00
00af9c6571 Cycles: add test file for various light types in volume
Weizhen Huang closed issue blender/blender#119855 2024-03-25 12:43:05 +01:00
Assert when stopping Cycles viewport render on macOS
Weizhen Huang commented on issue blender/blender#119855 2024-03-25 12:43:02 +01:00
Assert when stopping Cycles viewport render on macOS

Fixed by 7e2d54e786de74eb2e96d8e32cf2db53e5f7112f

Weizhen Huang pushed to main at weizhen/.profile 2024-03-22 19:12:38 +01:00
b5073d003c Update reports/2024.md
Weizhen Huang commented on pull request blender/blender#119389 2024-03-22 17:46:49 +01:00
Fix #114634: correlated samples in volume when using equiangular sampling and light tree

@brecht this PR is also ready. But it includes changes from #119438 in order to test them together, so might be difficult to read. I can remove those changes, or we look at this PR later.

Weizhen Huang commented on pull request blender/blender#119770 2024-03-22 17:01:24 +01:00
Fix #119692: Account for mesh lights with a light tree root index of 0

If we can not make the assumption anymore that the root index of the main tree is 0, and root_index is only used for traversing subtree here, I would rename it to subtree_index, or `subtree_roo…

Weizhen Huang commented on pull request blender/blender#119770 2024-03-22 16:12:34 +01:00
Fix #119692: Account for mesh lights with a light tree root index of 0

@Alaska without light linking, the right child of the root node is always reserved for distant/backgrounds lights, even if there are not present in the scene, so 0 can't be the leaf. I do not…

Weizhen Huang commented on pull request blender/blender#119770 2024-03-22 16:04:01 +01:00
Fix #119692: Account for mesh lights with a light tree root index of 0

@Sergey I am not sure if you misunderstood something or it was just typo, but without light linking 0 is the index of root node of the main tree, and the mesh lights have subtrees with non-zero…

Weizhen Huang pushed to fix-volume-light-tree at weizhen/blender 2024-03-22 15:08:00 +01:00
21af461948 Cleanup in comments
e95b884aef Cleanup to reduce noise
cd83b8f4bb Reduce storage
0f1ee83926 Add EMITTER_NONE
5425fb344c Use packed_float3 to save some space in LightSample
Compare 60 commits »