Seems to be fixed already. From the attached file I see nothing out of the ordinary, EEVEE and Cycles also match well.
The strength unit for mesh light is W/sr/m^2, integrated over the area and the hemisphere a factor of πA is expected, see blender/blender#108505 Can this…
Effectively we are still reusing the same random number to sample the light position from volume segment and from position, but that doesn't seem to cause problem as I observed. It was using the…
No. The change is that we determine the light to be sampled already in volume segment, not the light position. A new position would be sampled from the direct scattering position. Before this…
Fixed by 7e2d54e786de74eb2e96d8e32cf2db53e5f7112f
@brecht this PR is also ready. But it includes changes from #119438 in order to test them together, so might be difficult to read. I can remove those changes, or we look at this PR later.
If we can not make the assumption anymore that the root index of the main tree is 0, and root_index
is only used for traversing subtree here, I would rename it to subtree_index
, or `subtree_roo…
@Alaska without light linking, the right child of the root node is always reserved for distant/backgrounds lights, even if there are not present in the scene, so 0
can't be the leaf.
I do not…
@Sergey I am not sure if you misunderstood something or it was just typo, but without light linking 0
is the index of root node of the main tree, and the mesh lights have subtrees with non-zero…
@blender-bot build +gpu