Weizhen Huang weizhen
18 Followers · 0 Following
  • Joined on 2022-10-03
Repositories
2
 Projects Public Activity Starred Repositories
Weizhen Huang pushed to refactor_microfacet_fresnel at weizhen/blender 2023-09-13 14:09:26 +02:00
5722d64230 Address reviews
8a357d2ad8 Rename reflection -> reflectance, transmission -> transmittance
12e7b8f636 Merge branch 'main' into refactor_microfacet_fresnel
08eb7f1c97 GPv3: Snap selected grease pencil frames
564716d5a2 Fix #112285: Sculpt Mode: Mask brush smoothing is broken
Compare 99 commits »
Weizhen Huang commented on pull request blender/blender#112158 2023-09-13 12:55:46 +02:00
Refactor: Cycles: adjust microfacet lobe selection pdf by tint

Sergey said the convention in Blender is _sq, I have that in ray_sphere_intersect(), and am trying to name all the newly added variables with that suffix. But we have a lot mixed convention…

Weizhen Huang commented on pull request blender/blender#112158 2023-09-13 12:52:11 +02:00
Refactor: Cycles: adjust microfacet lobe selection pdf by tint

Would be better yes! This comes from an early iteration where I was thinking r can mean both reflection and refraction, but the reflection angle is not really needed here, it always equals to…

Weizhen Huang commented on pull request blender/blender#112158 2023-09-13 12:49:12 +02:00
Refactor: Cycles: adjust microfacet lobe selection pdf by tint

In bsdf_eval() the *pdf is initialized with zero, so it's not necessary to assign zero to *pdf again. I was thinking whether we should remove such assignment in all the bsdf_xxx_eval().…

Weizhen Huang pushed to principled-specular-tint at weizhen/blender 2023-09-12 19:40:20 +02:00
5983eecddc WIP: EEVEE: tint specular reflection in transmission component
Weizhen Huang commented on pull request blender/blender#112213 2023-09-11 11:40:05 +02:00
Cycles: Fix OSL potentially skipping closures when using layering

I don't really understand how it's working. With all these continue, return and do {} while (closure == nullptr) I find the flow quite hard to follow.

Weizhen Huang commented on pull request blender/blender#110993 2023-09-11 11:02:29 +02:00
Cycles: Rework Principled BSDF Clearcoat

I rewrote EEVEE principled BSDF #111754, and adjusted the part in this pull request so that it uses coat IOR instead of the default 1.5 in the merge commit 445464e5f2999a727d0795b05e0519b73a75b090

Weizhen Huang commented on pull request blender/blender#112192 2023-09-10 00:21:51 +02:00
Cycles/EEVEE: Change specular tint in Principled BSDF from float to color

Not sure about 7f28729e13, the transition seems smoother without the change. Probably should fix OSL instead.

Weizhen Huang created pull request blender/blender#112192 2023-09-10 00:15:09 +02:00
WIP: Cycles: Change specular tint in Principled BSDF from float to color
Weizhen Huang created branch principled-specular-tint in weizhen/blender 2023-09-10 00:05:44 +02:00
Weizhen Huang pushed to principled-specular-tint at weizhen/blender 2023-09-10 00:05:44 +02:00
7f28729e13 Fix: Cycles Principled BSDF specular component wrong IOR when backfacing
33181880d7 Cycles: Change specular tint in Principled BSDF from float to color
91a50f0aa0 Use square root of the base color for transmission color
7fb8834d30 Color f0 for transmission component
1e94c0e96a Use albedo instead of transmission_color for Fss
Compare 10 commits »
Weizhen Huang pushed to refactor_microfacet_fresnel at weizhen/blender 2023-09-08 19:35:23 +02:00
f05bd0bd11 Cleanup: rename variables in mnee for consistency
Weizhen Huang created pull request blender/blender#112158 2023-09-08 19:33:21 +02:00
Refactor: Cycles: weight reflection/refraction lobe selection pdf by tint
Weizhen Huang pushed to refactor_microfacet_fresnel at weizhen/blender 2023-09-08 19:32:47 +02:00
b003cdfb9e Refactor: Cycles: weight reflection/refraction lobe selection pdf by tint
Weizhen Huang created branch refactor_microfacet_fresnel in weizhen/blender 2023-09-08 19:32:47 +02:00
Weizhen Huang created pull request blender/blender#112157 2023-09-08 19:25:12 +02:00
Fix: Cycles: wrong refractive index in path guiding
Weizhen Huang pushed to fix-path-guiding-eta at weizhen/blender 2023-09-08 19:23:44 +02:00
41f6a01788 Fix: Cycles: wrong refractive index in path guiding
063a9e8964 Fix: Cycles: inconsistent normal checks when sampling and evaluating BSDF
87aa34d801 UI: Let asset shelf header resizing affect the entire asset shelf
cc1c38f74d UI: Fix inconsistent menu background padding
e7f1647785 Fix #112081: Incorrect Toolbar Context Highlighting
Compare 10 commits »
Weizhen Huang created branch fix-path-guiding-eta in weizhen/blender 2023-09-08 19:23:44 +02:00
Weizhen Huang pushed to main at blender/blender 2023-09-08 19:02:18 +02:00
063a9e8964 Fix: Cycles: inconsistent normal checks when sampling and evaluating BSDF
Weizhen Huang pushed to main at blender/blender 2023-09-08 17:19:58 +02:00
4c6164e292 Cleanup: fix typo in path guiding code