Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang merged pull request blender/blender#110307 2023-08-07 07:29:23 +02:00
Fix #110255: Cover up CPU/GPU differences with small suns in light tree
Weizhen Huang commented on pull request blender/blender#105600 2023-08-07 02:11:20 +02:00
Cycles: new Microfacet-based Hair BSDF with elliptical cross-section support

This piece of code is provided by @olivier.fx. I didn't came up with the logic myself, but for a far-field model the "normal" is always the incoming direction, not really a feature of the object…

Weizhen Huang commented on pull request blender/blender#105600 2023-08-07 02:08:16 +02:00
Cycles: new Microfacet-based Hair BSDF with elliptical cross-section support

For the current two enums yes, but named struct seems easier understandable. On the other hand, it introduces additional storage and is seen as a compromise for not having enum-typed sockets. I'm…

Weizhen Huang commented on pull request blender/blender#105600 2023-08-07 02:04:08 +02:00
Cycles: new Microfacet-based Hair BSDF with elliptical cross-section support

I don't see tooltips in any other shader nodes, so I'm not sure if there is a guideline here, and I also have no idea about UX. I thought it would be good to provide clear information here, so the…

Weizhen Huang commented on pull request blender/blender#105600 2023-08-07 02:01:19 +02:00
Cycles: new Microfacet-based Hair BSDF with elliptical cross-section support

In the original implementation the pdf involves sampling microfacets, it is as costly as evaluating the BSDF itself, and it is also just an approximation, so not sure if it's worth it and how to…

Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-08-04 18:24:28 +02:00
8e22265389 Merge remote-tracking branch 'origin' into microfacet_hair
e888002668 Cleanup: rearrange data nodes
4395e0da93 Fix: Geometry nodes self object crash in node operator
647f2053a9 Tests: add automated regressions tests for Hydra Storm
83fa353efc Hydra: add option to export through USD file instead of Hydra API
Compare 97 commits »
Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-08-04 16:51:29 +02:00
40e45dee57 Cleanup: remove unnecessary lines
91dae1866b Cleanup: rename functions
ae5176c92b Cleanup: format in comments
b278dbadbc Cleanup: move utility functions to bsdf_util.h
408c90224e Remove microfacet distribution type, use GGX
Compare 5 commits »
Weizhen Huang deleted branch copy_identifier from weizhen/blender 2023-08-04 16:32:44 +02:00
Weizhen Huang merged pull request blender/blender#110792 2023-08-04 16:32:42 +02:00
Nodes: Copy socket values with the same `identifier` instead of `name`
Weizhen Huang pushed to main at blender/blender 2023-08-04 16:32:41 +02:00
c36eccfae9 Nodes: Copy socket values with the same identifier instead of name
Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-08-04 12:57:42 +02:00
cc9c70d9ef Merge principled hair and microfacet hair in one shader node
Weizhen Huang created pull request blender/blender#110792 2023-08-04 12:53:34 +02:00
Nodes: Copy socket values with the same identifier instead of name
Weizhen Huang pushed to copy_identifier at weizhen/blender 2023-08-04 12:50:44 +02:00
91338d041c Nodes: Copy socket values with the same identifier instead of name
1f612605ab Fix #110732: blender_theme_as_c fails fails with error
1e1f4db8b6 Tools: add 'diff' and 'email' attrs to git_log utility module
ed6e24b176 Fix resource leak in git_log utility module
9ba38d5bb6 License checker: scan paths "*.inl;*.ch;*.osl;*.metal;*.tables"
Compare 10 commits »
Weizhen Huang created branch copy_identifier in weizhen/blender 2023-08-04 12:50:44 +02:00
Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-08-02 19:44:47 +02:00
b5eca9c2c5 Merge remote-tracking branch 'origin' into microfacet_hair
b655571f70 Render: Make GPU compositor a BaseRender method
5d0c355b5f Cleanup: Unsafe mix of type warning
c3685fe068 Cleanup: Sculpt: Use consistent operator function names
29a338811c Fix #110411: Mesh loop cut preview uses final instead of cage positions
Compare 1841 commits »
Weizhen Huang pushed to spectral_cycles at weizhen/blender 2023-08-02 12:16:07 +02:00
cb1b7c7a53 WIP: weight paths by the pdf to reduce color noise
Weizhen Huang pushed to spectral_cycles at weizhen/blender 2023-08-01 19:33:53 +02:00
cbbf82761b WIP: weight paths by the pdf to reduce color noise
b720a8b9c2 Cleanup: handle reflective and refractive lobes in microfacet_fresnel()
Compare 2 commits »
Weizhen Huang pushed to spectral_cycles at weizhen/blender 2023-07-31 19:00:42 +02:00
807d86eee5 Change pdf type from float to Spectrum
Weizhen Huang suggested changes for blender/blender#110307 2023-07-31 14:24:27 +02:00
Fix #110255: Cover up CPU/GPU differences with small suns in light tree

Such value seems quite arbitrary, I would lean towards assigning 1 to cos_theta when isequal(bcone.axis, -point_to_centroid) and comment that dot product doesn't necessarily returns 1 in such cases due to precision issue.