@Alaska Thanks for the extensive test files, I have started looking into the individual blend files.
I do not have commit access to the Blender repo or the tests repo.
For a proper…
Thanks! Seems like it was still using the hash of random_walk_fixed_radius
Analytic sounds more natural to me. Analytic model, analytic form, etc.
it should be
object:is_lampI think
I had this confusion before, and Brecht mentioned "lamp" is an outdated name we stopped using, it's just not applied everywhere yet.
I don't think we…
This should be inverse_lerp(range.x, range.y, theta)
For Metal it's 5% slower too, but if I render more samples it's about 2%. Initially I thought if self-intersection is handled properly now, then the performance penalty is worth it, but it seems…
@Alaska thanks!
Turns out there are self-intersections in the wdas_cloud scene. Not sure how the bounding boxes are generated and handled for vdb, will investigate later.
@Sergey can you check if the current change already causes a slowdown on GPU in the wdas_cloud scene? On Metal there are lots of fluctuations but this scene always seems slower.
@Sergey ok so the concern is that if things are not removed in order then it's not a stack, and if I insert an object next to itself then it's even less a stack. But I think to call it volume…
@Sergey As long as you remove one from the stack, it shouldn't matter which one, because the rest in the stack are going to be added together. But one problem I can see is when the object…
The motivation of the fix is the bug report #124385, where instances are considered separate objects, but become one after realizing instances. Although this PR fixes the artifacts, the appearance…