Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang commented on issue blender/blender#106876 2023-04-14 11:48:02 +02:00
Regression: LightTree failing with large number of emitters

Hi, I don't think 17c8e0d309 caused the issue. The light tree uses a bit trail with int type, which limits the tree depth to a maximum of 32, so it is expected that it will fail when dealing…

Weizhen Huang pushed to light_tree_instance at weizhen/blender 2023-04-14 00:36:18 +02:00
13a876dff7 Fix transform zero vector in volume
a56f7e1244 Parallelize iterating over mesh lights and building subtrees
e5b9a1050f Merge branch 'main' into light_tree_instance
8f9a92e3d7 Readability improvement based on reviews
71ed98debe Point Cloud: Avoid unnecessarily initializing initial positions
Compare 125 commits »
Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-04-13 17:39:33 +02:00
cc0e4cca1f Only 2 closures used
22f9898b4d Some cleanups
b47cc2aaa7 Remove unused node inputs
Compare 3 commits »
Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-04-13 14:28:15 +02:00
738f284e95 Minor cleanups
90cf06c874 Cleanup: de-duplicate code in closure.h
6ea34518b9 Merge remote-tracking branch 'origin' into microfacet_hair
e5d50b1787 Fix Cycles unknown passes logged when build with Cycles debug
34739f6a6d Fix #106672: MacOS/OpenGL doesn't draw anything Eevee related.
Compare 72 commits »
Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-04-12 18:49:56 +02:00
869fbcc712 Some comments
d07c115957 Fix compile error on GPU
dfbe7c544f Remove LABEL_TRANSMIT
a9534f0fdd Cleanup: reorder #MicrofacetHairBSDF and #MicrofacetHairExtra
Compare 4 commits »
Weizhen Huang commented on pull request blender/blender#106863 2023-04-12 16:31:43 +02:00
Fix Cycles unknown passes logged when build with Cycles debug

Shouldn't it be MAP_PASS(..., true) instead of false? It was originally PassMode::NOISY.

Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-04-12 15:00:02 +02:00
68605cd1c7 Modified position and description of the R, TT and TRT lobes
Weizhen Huang commented on pull request blender/blender#106764 2023-04-11 23:52:09 +02:00
Fix #106706: Fireflies with Nishita sky sun sampling at certain angles.

Thanks for investigating. I'm a bit worried about code duplication. I guess you can move the angle wrapping in sky_texture_precompute_nishita() to shader.cpp instead, just before `sky->set_su…

Weizhen Huang pushed to microfacet_hair at weizhen/blender 2023-04-11 18:42:50 +02:00
1cd5c44e68 Fix wrong projected radius in sampling
1ad653dae0 Merge remote-tracking branch 'origin' into microfacet_hair
90ad930a01 Fix #106778: Incomplete copy of curves radius to Cycles
f486679a3b Fix assert error with preview ball
4472717de2 Cleanup: Remove unnecessary PBVH attribute pointer
Compare 754 commits »
Weizhen Huang commented on pull request blender/blender#106683 2023-04-11 14:20:18 +02:00
Cycles: add instancing support in light tree

This array stores indices of the build-in lights (area light, spot light, sun light, point light), these lights are often called "lamps" throughout the code. Besides that we have mesh lights, which are kept in a separate array called mesh_to_light. Because both types are called "lights", I thought it would be less confusing to rename the other one to lamp_to_tree.

Weizhen Huang commented on pull request blender/blender#106683 2023-04-07 18:41:55 +02:00
Cycles: add instancing support in light tree
Weizhen Huang created pull request blender/blender#106683 2023-04-07 18:41:37 +02:00
Cycles: speed up light tree build with many instanced mesh lights
Weizhen Huang pushed to light_tree_instance at weizhen/blender 2023-04-07 18:40:57 +02:00
dec90cfcf9 Cycles: speed up light tree build with many instanced mesh lights
Weizhen Huang pushed to light_tree_instance at weizhen/blender 2023-04-07 18:39:14 +02:00
801e0c186b Cycles: speedup light tree build with many instanced mesh lights
44d5a894c1 Fix #106667: Cycles: Multi-device denoise runs denoising data passes
ade103d7b8 Depsgrpah: Fix 'use after free' invalid access to stored keys names.
4ab7bb5b1f Fix : Show 'Exit group' menu entry also for non group nodes.
75c0e808b8 Fix #106103: Resolve texture paint selection in Metal
Compare 10 commits »
Weizhen Huang created branch light_tree_instance in weizhen/blender 2023-04-07 18:39:14 +02:00
Weizhen Huang deleted branch motion_triangle_deduplicate from weizhen/blender 2023-04-06 17:28:55 +02:00
Weizhen Huang merged pull request blender/blender#106629 2023-04-06 17:28:53 +02:00
Refactor: de-duplicate motion triangle vertices and normals computation
Weizhen Huang pushed to main at blender/blender 2023-04-06 17:28:52 +02:00
390a63b264 Refactor: de-duplicate motion triangle vertices and normals computation