Weizhen Huang weizhen
19 Followers · 0 Following
  • Joined on 2022-10-03
Repositories
2
 Projects Public Activity Starred Repositories
Weizhen Huang commented on pull request blender/blender#118477 2024-04-22 12:31:08 +02:00
Cycles: Add thin film iridescence to Principled BSDF

This does not compile on Metal. Add ccl_private.

Weizhen Huang commented on pull request blender/blender#118477 2024-04-22 12:26:44 +02:00
Cycles: Add thin film iridescence to Principled BSDF

For cognitive ease I would prefer to add an empty if (fresnel->thin_film.thickness > 0.1f) branch and put the comment there, the following block is then put in the else branch

Weizhen Huang commented on pull request blender/blender#118477 2024-04-22 12:26:43 +02:00
Cycles: Add thin film iridescence to Principled BSDF

We use nullptr now.

Weizhen Huang commented on pull request blender/blender#118477 2024-04-22 12:26:42 +02:00
Cycles: Add thin film iridescence to Principled BSDF

The newly added sqr() is not used, I assume you wanted to use it here?

Weizhen Huang pushed to main at weizhen/.profile 2024-04-22 00:00:22 +02:00
0ac072338e Update reports/2024.md
Weizhen Huang commented on pull request blender/blender#118477 2024-04-21 20:25:10 +02:00
Cycles: Add thin film iridescence to Principled BSDF

Yes, you are right, I was not paying attention to the denominator. I remember switching the order was only to make the two lines have the same structure because the sign didn't matter. Sorry for…

Weizhen Huang commented on pull request blender/blender#118477 2024-04-21 20:13:02 +02:00
Cycles: Add thin film iridescence to Principled BSDF

Do you mean the sign of cos_theta_t? In fresnel_dielectric() it is the angle between the surface normal and the refracted ray, hence negative, and the sign is used in Principled Hair Huang I…

Weizhen Huang pushed to restir at weizhen/blender 2024-04-19 18:21:21 +02:00
f7e93cca5d Randomly sample neighbors instead of deterministically to reduce artifact
6c468666a2 Refactor: use sample sequences in reservoir sampling
f02f623637 Refactor: use int to represent initial and spatial resampling
66b5e9cb41 Fix checking visibility when ReSTIR is not used
Compare 4 commits »
Weizhen Huang pushed to restir at weizhen/blender 2024-04-19 01:39:37 +02:00
4da7e9f1d1 Put BSDF samples in reservoir when spatial resampling is enabled
Weizhen Huang pushed to restir at weizhen/blender 2024-04-19 00:16:55 +02:00
e44dd9b1c9 Fix biase in spatial resampling
Weizhen Huang pushed to restir at weizhen/blender 2024-04-18 21:50:57 +02:00
76d2609896 Fix division by zero
a3b883bf59 Add options to check sample visibility
Compare 2 commits »
Weizhen Huang pushed to restir at weizhen/blender 2024-04-18 15:28:53 +02:00
d33ec9567c Add more ReSTIR options
Weizhen Huang pushed to restir at weizhen/blender 2024-04-18 09:34:30 +02:00
fc3b69435a Add option to use ReSTIR
f7b9351840 Fix crash without light tree
48d5db3081 Cycles: Implement blue-noise dithered sampling
Compare 3 commits »
Weizhen Huang pushed to restir at weizhen/blender 2024-04-17 19:12:17 +02:00
636b7254e5 Add spatial resampling
68cc87d9ba Refactor: make restir an init function
758481d375 Cleanup: comments, change function parameters, split reservoir and sd
89a12ead7d Refactor: move 1/pdf to weight instead of a multiplicator of radiance
3a26a601f4 Remove ReSTIR from megakernel
Compare 95 commits »
Weizhen Huang deleted branch cycles-cleanup from weizhen/blender 2024-04-17 18:49:18 +02:00
Weizhen Huang merged pull request blender/blender#120714 2024-04-17 18:49:16 +02:00
Cleanup: various cleanups in Cycles kernel
Weizhen Huang pushed to main at blender/blender 2024-04-17 18:49:15 +02:00
8e5840359f Refactor: deduplicate assignment of background light group
a6330cad7f Refactor: wrap block of codes into a function
45d2e46752 Cleanup: remove unnecessary shader flag in Chiang Hair BSDF
481b50e06d Cleanup: pass shader flag as parameter instead of ShaderData
2e1380fa0c Cleanup: use available function to compute render buffer pointer
Compare 7 commits »
Weizhen Huang commented on pull request blender/blender#120714 2024-04-17 18:30:39 +02:00
Cleanup: various cleanups in Cycles kernel

@blender-bot build

Weizhen Huang pushed to cycles-cleanup at weizhen/blender 2024-04-17 18:29:44 +02:00
cbaf9e0eb8 Refactor: deduplicate assignment of background light group
654801a6b8 Refactor: wrap block of codes into a function
f09ab0fe7b Cleanup: remove unnecessary shader flag in Chiang Hair BSDF
858de3f393 Cleanup: pass shader flag as parameter instead of ShaderData
bbdd8f422c Cleanup: use available function to compute render buffer pointer
Compare 6 commits »
Weizhen Huang pushed to cycles-cleanup at weizhen/blender 2024-04-17 12:35:48 +02:00
30c4ccf3b2 Add # ifdef __HAIR__ back